[PATCH v2 0/2] Explicitly fflush stdout in git clean
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Apr 10, 2020, 11:27 UTC
- Message-ID
- <pull.755.v2.git.git.1586518072.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.755.git.git.1586374380709.gitgitgadget@gmail.com>
This is yet another patch that was funneled through a Git for Windows PR, read: it has been battle-tested.
Of course, the current iteration of this patch series has not been battle-tested, so please do review carefully, so that we can prevent bugs from slipping in during the review process.
Changes since v1:
* Added a preparatory patch that refactors all interactive input reading via strbuf_getline(..., stdin). * Adjusted the patch and its commit message accordingly.
Johannes Schindelin (1): Refactor code asking the user for input interactively
마누엘 (1): Explicitly `fflush` stdout before expecting interactive input
add-interactive.c | 4 ++-- add-patch.c | 4 ++-- builtin/clean.c | 14 ++++---------- prompt.c | 12 ++++++++++++ prompt.h | 2 ++ shell.c | 4 ++-- 6 files changed, 24 insertions(+), 16 deletions(-)
base-commit: 9fadedd637b312089337d73c3ed8447e9f0aa775 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-755%2Fdscho%2Ffflush-in-git-clean-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-755/dscho/fflush-in-git-clean-v2 Pull-Request: https://github.com/git/git/pull/755
Range-diff vs v1:
1: 21acd883b94 < -: ----------- clean: explicitly `fflush` stdout -: ----------- > 1: 9d2ee78a9e4 Refactor code asking the user for input interactively -: ----------- > 2: d3949e42004 Explicitly `fflush` stdout before expecting interactive input
-- gitgitgadget