git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] contrib/buildsystems: fix expat library name for generated vcxproj

From
Orgad Shaneh via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 7, 2020, 06:00 UTC
Message-ID
<pull.728.git.1599458405948.gitgitgadget@gmail.com>
From: Orgad Shaneh <orgads@gmail.com>
expat.lib -> libexpat.lib (libexpatd.lib for debug build).
Signed-off-by: Orgad Shaneh <orgads@gmail.com>
---
    contrib/buildsystems: fix expat library name for generated vcxproj
    
    expat.lib -> libexpat.lib (libexpatd.lib for debug build).
    
    Signed-off-by: Orgad Shaneh orgads@gmail.com [orgads@gmail.com]
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-728%2Forgads%2Fvcxproj-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-728/orgads/vcxproj-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/728
 contrib/buildsystems/Generators/Vcxproj.pm | 1 +
 contrib/buildsystems/engine.pl             | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/contrib/buildsystems/Generators/Vcxproj.pm b/contrib/buildsystems/Generators/Vcxproj.pm
index 5c666f9ac0..d2584450ba 100644
--- a/contrib/buildsystems/Generators/Vcxproj.pm
+++ b/contrib/buildsystems/Generators/Vcxproj.pm
@@ -80,6 +80,7 @@ sub createProject {
       $libs_release = join(";", sort(grep /^(?!libgit\.lib|xdiff\/lib\.lib|vcs-svn\/lib\.lib)/, @{$$build_structure{"$prefix${name}_LIBS"}}));
       $libs_debug = $libs_release;
       $libs_debug =~ s/zlib\.lib/zlibd\.lib/g;
+      $libs_debug =~ s/libexpat\.lib/libexpatd\.lib/g;
       $libs_debug =~ s/libcurl\.lib/libcurl-d\.lib/g;
     }
 
diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
index 070978506a..2ff9620459 100755
--- a/contrib/buildsystems/engine.pl
+++ b/contrib/buildsystems/engine.pl
@@ -349,7 +349,7 @@ sub handleLinkLine
         } elsif ("$part" eq "-lcurl") {
             push(@libs, "libcurl.lib");
         } elsif ("$part" eq "-lexpat") {
-            push(@libs, "expat.lib");
+            push(@libs, "libexpat.lib");
         } elsif ("$part" eq "-liconv") {
             push(@libs, "libiconv.lib");
         } elsif ($part =~ /^[-\/]/) {

base-commit: e19713638985533ce461db072b49112da5bd2042
-- 
gitgitgadget
Next: Johannes Schindelin
Message 1 of 2 in “contrib/buildsystems: fix expat library name for generated vcxproj”
  1. contrib/buildsystems: fix expat library name for generated vcxprojOrgad Shaneh via GitGitGadget, Sep 7, 2020
  2. Johannes SchindelinSep 7, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.