git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Graph horizontal fix

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Jan 8, 2020, 04:27 UTC
Message-ID
<pull.518.git.1578457675.gitgitgadget@gmail.com>
This depends on ds/graph-assert-fix.

This is a non-critical (not needed for v2.25.0) response to the previous discussions [1] [2].

While working to resolve the fix for the assert() bug, I noticed this regression when multiple edges wanted to collapse with horizontal lines. It takes a reasonably large graph, but real projects are likely to demonstrate this behavior.

I arranged the series into two patches: 1. the (failing) test, and 2. the fix.

The fix commit includes some details about why the change to compress merge commits caused this regression, and why I feel relatively confident that this is a correct resolution.

Thanks, -Stolee

[1] https://lore.kernel.org/git/faa954fa-ccb9-b034-a39d-d2f0696826ea@gmail.com/T/#t [2] https://lore.kernel.org/git/xmqqk1635gwu.fsf@gitster-ct.c.googlers.com/T/#t

Derrick Stolee (2):
  graph: add test to demonstrate horizontal line bug
  graph: fix collapse of multiple edges
 graph.c                      | 10 ++++--
 t/t4215-log-skewed-merges.sh | 62 ++++++++++++++++++++++++++++++++++++
 2 files changed, 70 insertions(+), 2 deletions(-)
base-commit: aa2121af50498c7ea9d5c4c87f9dc66605bf772b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-518%2Fderrickstolee%2Fgraph-horizontal-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-518/derrickstolee/graph-horizontal-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/518
-- 
gitgitgadget
Next: Derrick Stolee via GitGitGadget
Message 1 of 9 in “Graph horizontal fix”
  1. 0/2 Graph horizontal fixDerrick Stolee via GitGitGadget, Jan 8, 2020
  2. 1/2 graph: add test to demonstrate horizontal line bugDerrick Stolee via GitGitGadget, Jan 8, 2020
  3. 2/2 graph: fix collapse of multiple edgesDerrick Stolee via GitGitGadget, Jan 8, 2020
  4. Jeff KingJan 8, 2020
  5. Derrick StoleeJan 8, 2020
  6. Jeff KingJan 8, 2020
  7. Junio C HamanoJan 8, 2020
  8. Derrick StoleeJan 8, 2020
  9. Junio C HamanoJan 8, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.