git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix locking issues with git fetch --multiple --jobs=<n> and fetch.writeCommitGraph

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 3, 2019, 00:21 UTC
Message-ID
<pull.443.git.1572740518.gitgitgadget@gmail.com>

The git fetch command recently learned to extend the --jobs=<n> option to cover the --multiple mode: it will run multiple fetches in parallel.

Together with the recent support to write commit-graphs automatically after each fetch by setting fetch.writeCommitGraph, this led to frequent issues where the commit-graph-chain.lock file could not be created because a parallel job had already created it.

This pair of patches first introduces the command-line option --write-commit-graph (together with the --no-* variant) and then uses it to avoid writing the commit-graph until all fetch jobs are complete.

I don't think that we will want to rush this into Git v2.24.0 because that release is imminent, and this is quite a corner case that I am fixing here. It's more of a FYI that I send this before v2.24.0 is available.

Johannes Schindelin (2):
  fetch: add the command-line option `--write-commit-graph`
  fetch: avoid locking issues between fetch.jobs/fetch.writeCommitGraph
 Documentation/fetch-options.txt |  4 ++++
 builtin/fetch.c                 | 10 ++++++++--
 2 files changed, 12 insertions(+), 2 deletions(-)
base-commit: efd54442381a2792186abc994060b8f7dd8b834b
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-443%2Fdscho%2Ffetch.writeCommitGraph-and-fetch-jobs-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-443/dscho/fetch.writeCommitGraph-and-fetch-jobs-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/443
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 6 in “Fix locking issues with git fetch --multiple --jobs=<n> and fetch.writeCommitGraph”
  1. 0/2 Fix locking issues with git fetch --multiple --jobs=<n> and fetch.writeCommitGraphJohannes Schindelin via GitGitGadget, Nov 3, 2019
  2. 1/2 fetch: add the command-line option `--write-commit-graph`Johannes Schindelin via GitGitGadget, Nov 3, 2019
  3. 2/2 fetch: avoid locking issues between fetch.jobs/fetch.writeCommitGraphJohannes Schindelin via GitGitGadget, Nov 3, 2019
  4. Jeff KingNov 4, 2019
  5. Junio C HamanoNov 6, 2019
  6. Johannes SchindelinNov 6, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.