git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] Add coverage for 'git format-patch --range-diff' single-patch case

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 12, 2018, 14:31 UTC
Message-ID
<pull.37.v2.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.37.git.gitgitgadget@gmail.com>

In es/format-patch-rangediff, we added a '--range-diff' option to git-format-patch to automatically add a range-diff. We also added an option to write the diff as commentary to a single patch submission. However, this check was not tested.

I discovered this test gap by running 'make coverage-test coverage-report' on 'next' and then comparing the uncovered lines with those in the diff between 'master' and 'next'. I have a script that automates this process, and I'm still working on polishing it. You can see an earlier version at [1].

Based on es/format-patch-rangediff
Cc: sunshine@sunshine.co
Cc: peff@peff.net

[1] https://github.com/derrickstolee/git/blob/coverage/contrib/coverage-diff.shA bash script to report uncovered lines that were added in a diff.

Derrick Stolee (1):
  t3206-range-diff.sh: cover single-patch case
 t/t3206-range-diff.sh | 5 +++++
 1 file changed, 5 insertions(+)
base-commit: 40ce41604daf200cdc85abded0133d40faafc2f8
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-37%2Fderrickstolee%2Frange-diff-test-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-37/derrickstolee/range-diff-test-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/37
Range-diff vs v1:
 1:  58347a9624 ! 1:  277a4d2bd8 t3206-range-diff.sh: cover single-patch case
     @@ -22,7 +22,7 @@
       
      +test_expect_success 'format-patch --range-diff as commentary' '
      +	git format-patch --stdout --range-diff=HEAD~1 HEAD~1 >actual &&
     -+	grep -A 1 -e "\-\-\-" actual | grep "Range-diff:"
     ++	test_i18ngrep "^Range-diff:$" actual
      +'
      +
       test_done
-- 
gitgitgadget
Previous: Eric SunshineNext: Derrick Stolee via GitGitGadget
Message 10 of 11 in “Add coverage for 'git format-patch --range-diff' single-patch case”
  1. 0/1 Add coverage for 'git format-patch --range-diff' single-patch caseDerrick Stolee via GitGitGadget, Sep 11, 2018
  2. 1/1 t3206-range-diff.sh: cover single-patch caseDerrick Stolee via GitGitGadget, Sep 11, 2018
  3. Junio C HamanoSep 11, 2018
  4. Junio C HamanoSep 11, 2018
  5. Stefan BellerSep 11, 2018
  6. Eric SunshineSep 11, 2018
  7. Derrick StoleeSep 12, 2018
  8. Derrick StoleeSep 11, 2018
  9. Eric SunshineSep 11, 2018
  10. 0/1 Add coverage for 'git format-patch --range-diff' single-patch caseDerrick Stolee via GitGitGadget, Sep 12, 2018
  11. 1/1 t3206-range-diff.sh: cover single-patch caseDerrick Stolee via GitGitGadget, Sep 12, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.