git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] commit-graph: add --[no-]progress to write and verify

From
GGGarima Singh via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 20, 2019, 18:37 UTC
Message-ID
<pull.315.git.gitgitgadget@gmail.com>
Hey Git contributors! 

My name is Garima Singh and I work at Microsoft. I recently started working closely with the Microsoft team contributing to the git client ecosystem. I am very glad to have the opportunity to work with this community. I am new to the world of git client development but I did work on the Git service offering of Azure Developer Services for a few years. I am sure I will get to learn a lot from all of you.

Dr. Derrick Stolee helped me pick out my first task (Thanks Stolee!) He mentioned an issue in the commit-graph builtin where git did not support opting in and out of the progress output. This was bloating up the stderr logs in VFS for Git. The progress feature was introduced in 7b0f229222 ("commit-graph write: add progress output", 2018-09-17) but the ability to opt-out was overlooked. This patch adds the --no-progress option so that callers can control the amount of logging they receive.

Looking forward to your review. Cheers! Garima Singh
CC: stolee@gmail.com, avarab@gmail.com, garimasigit@gmail.com
Garima Singh (1):
  commit-graph: add --[no-]progress to write and verify.
 Documentation/git-commit-graph.txt |  4 +++-
 builtin/commit-graph.c             | 29 +++++++++++++++++-------
 commit-graph.c                     |  7 ++++--
 t/t5318-commit-graph.sh            | 36 ++++++++++++++++++++++++++++++
 t/t5324-split-commit-graph.sh      |  2 +-
 5 files changed, 66 insertions(+), 12 deletions(-)
base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-315%2Fgarimasi514%2FcoreGit-commit-graph-progress-toggle-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-315/garimasi514/coreGit-commit-graph-progress-toggle-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/315
-- 
gitgitgadget
Next: Garima Singh via GitGitGadget
Message 1 of 13 in “commit-graph: add --[no-]progress to write and verify”
  1. 0/1 commit-graph: add --[no-]progress to write and verifyGarima Singh via GitGitGadget, Aug 20, 2019
  2. 1/1 commit-graph: add --[no-]progress to write and verify.Garima Singh via GitGitGadget, Aug 20, 2019
  3. Junio C HamanoAug 20, 2019
  4. Eric SunshineAug 20, 2019
  5. Junio C HamanoAug 21, 2019
  6. Derrick StoleeAug 20, 2019
  7. 0/1 commit-graph: add --[no-]progress to write and verifyGarima Singh via GitGitGadget, Aug 26, 2019
  8. 1/1 commit-graph: add --[no-]progress to write and verify.Garima Singh via GitGitGadget, Aug 26, 2019
  9. Junio C HamanoSep 12, 2019
  10. SZEDER GáborSep 16, 2019
  11. Derrick StoleeSep 17, 2019
  12. SZEDER GáborSep 17, 2019
  13. Garima SinghSep 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.