[PATCH 0/1] quote: handle null and empty strings in sq_quote_buf_pretty()
- From
- Garima Singh via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Aug 20, 2019, 19:35 UTC
- Message-ID
- <pull.314.git.gitgitgadget@gmail.com>
Hey,
In [1], Junio described a potential bug in sq_quote_buf_pretty() when the arg is a zero length string and how he believes the method should behave. This commit teaches sq_quote_buf_pretty to emit '' for null and empty strings.
Looking forward to your review. Cheers! Garima Singh
[1] https://public-inbox.org/git/pull.298.git.gitgitgadget@gmail.com/T/#m9e33936067ec2066f675aa63133a2486efd415fd
Garima Singh (1): quote: handle null and empty strings in sq_quote_buf_pretty()
Makefile | 1 + quote.c | 9 +++++++ t/helper/test-quote.c | 28 +++++++++++++++++++++ t/helper/test-tool.c | 1 + t/helper/test-tool.h | 1 + t/t0091-quote.sh | 58 +++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 98 insertions(+) create mode 100644 t/helper/test-quote.c create mode 100755 t/t0091-quote.sh
base-commit: 5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-314%2Fgarimasi514%2FcoreGit-fixQuote-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-314/garimasi514/coreGit-fixQuote-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/314
-- gitgitgadget