git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/1] [v2.23.0 BUG] commit-graph: fix bug around octopus merges

From
Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 5, 2019, 16:43 UTC
Message-ID
<pull.308.git.gitgitgadget@gmail.com>

I come, hat in hand, with a bug-fix for a bug that I wrote. I just happened to discover this issue while playing around with turning the commit-graph on by default and stumbled into this warning.

Please see the commit message for full details, but putting octopus merges in a tip commit-graph file in the incremental format [1] would cause the file to not load because Git thinks the base commit-graphs do not have the right hashes.

It is very likely that a more careful patch would allow this warning to become an error during git commit-graph verify, but I wanted to minimize the change for this quick bug fix.

Thanks, -Stolee
[1] https://public-inbox.org/git/pull.184.v6.git.gitgitgadget@gmail.com/
Derrick Stolee (1):
  commit-graph: fix bug around octopus merges
 commit-graph.c                | 2 +-
 t/t5324-split-commit-graph.sh | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)
base-commit: 5b15eb397d176c557a82e872d6b4043aa7589874
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-308%2Fderrickstolee%2Fcommit-graph-octopus-bug-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-308/derrickstolee/commit-graph-octopus-bug-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/308
-- 
gitgitgadget
Next: Derrick Stolee via GitGitGadget
Message 1 of 5 in “[v2.23.0 BUG] commit-graph: fix bug around octopus merges”
  1. 0/1 [v2.23.0 BUG] commit-graph: fix bug around octopus mergesDerrick Stolee via GitGitGadget, Aug 5, 2019
  2. 1/1 commit-graph: fix bug around octopus mergesDerrick Stolee via GitGitGadget, Aug 5, 2019
  3. SZEDER GáborAug 6, 2019
  4. Derrick StoleeAug 6, 2019
  5. SZEDER GáborAug 6, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.