git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] pkt-line: initialize packet_buffer to avoid macOS linker warning

From
Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com>
Date
May 27, 2026, 17:11 UTC
Message-ID
<pull.2313.git.git.1779901919956.gitgitgadget@gmail.com>
From: Harald Nordgren <haraldnordgren@gmail.com>
Signed-off-by: Harald Nordgren <haraldnordgren@gmail.com>
---
    pkt-line: initialize packet_buffer to avoid macOS linker warning
    
    Removes this warning:
    
    $ make -s -j8
    GIT_VERSION=2.54.0.380.gc69baaf57b
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment
    
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2313%2FHaraldNordgren%2Fpkt-line-init-buffer-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2313/HaraldNordgren/pkt-line-init-buffer-v1
Pull-Request: https://github.com/git/git/pull/2313
 pkt-line.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkt-line.c b/pkt-line.c
index 3fc3e9ea70..cfd2799677 100644
--- a/pkt-line.c
+++ b/pkt-line.c
@@ -8,7 +8,7 @@
 #include "trace.h"
 #include "write-or-die.h"
 
-char packet_buffer[LARGE_PACKET_MAX];
+char packet_buffer[LARGE_PACKET_MAX] = {0};
 static const char *packet_trace_prefix = "git";
 static struct trace_key trace_packet = TRACE_KEY_INIT(PACKET);
 static struct trace_key trace_pack = TRACE_KEY_INIT(PACKFILE);

base-commit: c69baaf57ba26cf117c2b6793802877f19738b0d
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 8 in “pkt-line: initialize packet_buffer to avoid macOS linker warning”
  1. pkt-line: initialize packet_buffer to avoid macOS linker warningHarald Nordgren via GitGitGadget, May 27, 2026
  2. Junio C HamanoMay 28, 2026
  3. Harald NordgrenMay 28, 2026
  4. Harald NordgrenMay 28, 2026
  5. Junio C HamanoMay 28, 2026
  6. config.mak.uname: avoid macOS linker warning on Xcode 16.3+Harald Nordgren via GitGitGadget, May 29, 2026
  7. Junio C HamanoJun 1, 2026
  8. config.mak.uname: avoid macOS linker warning on Xcode 16.3+Harald Nordgren via GitGitGadget, Jun 2, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.