[PATCH 00/12] Next size_t stop: pack-objects/delta
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Jul 9, 2026, 16:49 UTC
- Message-ID
- <pull.2175.git.1783615780.gitgitgadget@gmail.com>
This patch series continues the effort to stop using unsigned long where size_t should have been used in the first place. This makes a difference on 64-bit Windows, where unsigned long is 32-bit.
With these fixes, the pack-objects machinery works as intended on 64-bit Windows (and any other 64-bit platform where unsigned long isn't 64-bit).
Johannes Schindelin (12):
diff-delta: widen `struct delta_index`' size fields to `size_t`
delta: widen `create_delta_index()` parameter to `size_t`
pack-objects: widen delta-cache accounting to `size_t`
pack-objects: widen `free_unpacked()` return to `size_t`
pack-objects: widen `mem_usage` and `try_delta()`'s out-param to
`size_t`
delta: widen `create_delta()` and `diff_delta()` to `size_t`
packfile, git-zlib: widen `use_pack()` and zstream avail fields to
`size_t`
archive-zip: widen `zlib_deflate_raw()`'s maxsize local to `size_t`
diff: widen `deflate_it()`'s bound local from int to `size_t`
http-push: widen `start_put()`'s size local from `ssize_t` to `size_t`
t/helper/test-pack-deltas: widen `do_compress()`'s maxsize local to
`size_t`
git-zlib: widen `git_deflate_bound()` to `size_t`archive-zip.c | 2 +- builtin/fast-import.c | 6 ++++-- builtin/pack-objects.c | 30 ++++++++++++++++-------------- delta.h | 12 ++++++------ diff-delta.c | 12 ++++++------ diff.c | 6 ++++-- git-zlib.c | 16 ++++++++++++++-- git-zlib.h | 6 +++--- http-push.c | 2 +- pack-check.c | 4 ++-- packfile.c | 4 ++-- packfile.h | 3 ++- t/helper/test-delta.c | 2 +- t/helper/test-pack-deltas.c | 7 ++++--- 14 files changed, 66 insertions(+), 46 deletions(-)
base-commit: f85a7e662054a7b0d9070e432508831afa214b47 Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2175%2Fdscho%2Fsize-t%2Fpack-objects-delta-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2175/dscho/size-t/pack-objects-delta-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/2175
-- gitgitgadget