git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] sequencer: remove todo_add_branch_context.commit

From
Abhinav Gupta via GitGitGadget <gitgitgadget@gmail.com>
Date
May 11, 2026, 12:21 UTC
Message-ID
<pull.2111.git.1778502113485.gitgitgadget@gmail.com>
From: Abhinav Gupta <mail@abhinavg.net>

The 'commit' field in 'struct todo_add_branch_context' is unused. It's written to, but never read from. add_decorations_to_list() gets the commit passed to it explicitly as an argument.

Signed-off-by: Abhinav Gupta <mail@abhinavg.net>
---
    sequencer: remove todo_add_branch_context.commit
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-2111%2Fabhinav%2Fsequencer-todoctx-rm-commit-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-2111/abhinav/sequencer-todoctx-rm-commit-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/2111
 sequencer.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index b7d8dca47f..19839da1e6 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -6409,7 +6409,6 @@ struct todo_add_branch_context {
 	size_t items_nr;
 	size_t items_alloc;
 	struct strbuf *buf;
-	struct commit *commit;
 	struct string_list refs_to_oids;
 };
 
@@ -6498,7 +6497,6 @@ static int todo_list_add_update_ref_commands(struct todo_list *todo_list)
 		ctx.items[ctx.items_nr++] = todo_list->items[i++];
 
 		if (item->commit) {
-			ctx.commit = item->commit;
 			add_decorations_to_list(item->commit, &ctx);
 		}
 	}

base-commit: 94f057755b7941b321fd11fec1b2e3ca5313a4e0
-- 
gitgitgadget
Next: Patrick Steinhardt
Message 1 of 2 in “sequencer: remove todo_add_branch_context.commit”
  1. sequencer: remove todo_add_branch_context.commitAbhinav Gupta via GitGitGadget, May 11, 2026
  2. Patrick SteinhardtMay 12, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.