git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] win32: pthread_cond_wait should return a value

From
AGAZero13 via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 18, 2025, 00:59 UTC
Message-ID
<pull.2103.git.git.1763427599300.gitgitgadget@gmail.com>
From: AZero13 <gfunni234@gmail.com>
This value is not checked, but it must return to match POSIX
Signed-off-by: Greg Funni <gfunni234@gmail.com>
---
    win32: pthread_cond_wait should return a value
    
    This value is not checked, but it must return to match POSIX
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2103%2FAZero13%2Fpthread-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2103/AZero13/pthread-v1
Pull-Request: https://github.com/git/git/pull/2103
 compat/win32/pthread.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/compat/win32/pthread.h b/compat/win32/pthread.h
index e2b5c4f64c..000604cdf6 100644
--- a/compat/win32/pthread.h
+++ b/compat/win32/pthread.h
@@ -34,7 +34,7 @@ typedef int pthread_mutexattr_t;
 
 #define pthread_cond_t CONDITION_VARIABLE
 
-#define pthread_cond_init(a,b) InitializeConditionVariable((a))
+#define pthread_cond_init(a,b) return_0((InitializeConditionVariable((a)), 0))
 #define pthread_cond_destroy(a) do {} while (0)
 #define pthread_cond_wait(a,b) return_0(SleepConditionVariableCS((a), (b), INFINITE))
 #define pthread_cond_signal WakeConditionVariable

base-commit: 9a2fb147f2c61d0cab52c883e7e26f5b7948e3ed
-- 
gitgitgadget
Next: AZero13 via GitGitGadget
Message 1 of 6 in “win32: pthread_cond_wait should return a value”
  1. win32: pthread_cond_wait should return a valueAZero13 via GitGitGadget, Nov 18, 2025
  2. win32: pthread_cond_wait should return a valueAZero13 via GitGitGadget, Nov 18, 2025
  3. Junio C HamanoNov 18, 2025
  4. win32: pthread_cond_init should return a valueAZero13 via GitGitGadget, Nov 20, 2025
  5. Junio C HamanoNov 21, 2025
  6. Junio C HamanoDec 7, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.