git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] Make t2024 NO_PERL-safe

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 23, 2018, 14:41 UTC
Message-ID
<pull.20.v2.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.20.git.gitgitgadget@gmail.com>

While trying to run the build & test with NO_PERL, I noticed that t2024 had a failing test case. This patch works around that failing test case by skipping it when we know that the error message looks different than that test case would expect.

Changes since v1 (which did not make it to the list due to https://github.com/gitgitgadget/gitgitgadget/issues/29):

 * reworded the commit message slightly.
Johannes Schindelin (1):
  t2024: mark a `checkout -p` test as requiring Perl
 t/t2024-checkout-dwim.sh | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
base-commit: 8d7b558baebe3abbbad4973ce1e1f87a7da17f47
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-20%2Fdscho%2Fcheckout-default-remote-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-20/dscho/checkout-default-remote-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/20
Range-diff vs v1:
 1:  619d7bcc31 ! 1:  8d46b31f5a t2024: mark a `checkout -p` test as requiring Perl
     @@ -3,9 +3,11 @@
          t2024: mark a `checkout -p` test as requiring Perl
      
          A recently-added test case tries to verify that the output of `checkout
     -    -p` contains a certain piece of advice. But if Git was built without
     -    Perl and therefore lacks support for `git add -i`, the error output
     -    contains the hint that `-p` is not even available instead.
     +    -p` contains a certain piece of advice.
     +
     +    But if Git was built without Perl and therefore lacks support for `git
     +    add -i`, the error output contains the hint that `-p` is not even
     +    available instead.
      
          Let's just skip that test case altogether if Git was built with NO_PERL.
      
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 4 in “Make t2024 NO_PERL-safe”
  1. 0/1 Make t2024 NO_PERL-safeJohannes Schindelin via GitGitGadget, Aug 23, 2018
  2. 1/1 t2024: mark a `checkout -p` test as requiring PerlJohannes Schindelin via GitGitGadget, Aug 23, 2018
  3. Ævar Arnfjörð BjarmasonAug 23, 2018
  4. Johannes SchindelinAug 23, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.