[PATCH] commit-graph: fix start_delayed_progress() leak

From: Lidong Yan via GitGitGadget <gitgitgadget@gmail.com>
Date: Jun 4, 2025, 03:11 UTC
Message-ID: <pull.1986.git.git.1749006675784.gitgitgadget@gmail.com>

From: Lidong Yan <502024330056@smail.nju.edu.cn>

In commit-graph.c:graph_write(), if read_one_commit() failed, progress allocated in start_delayed_progress() will leak. Add stop_progress() before goto cleanup.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
---
    commit-graph: fix start_delayed_progress() leak
    
    In commit-graph.c:graph_write(), if read_one_commit() failed, progress
    allocated in start_delayed_progress() will leak. Add stop_progress()
    before goto cleanup.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1986%2Fbrandb97%2Ffix-graph-write-leak-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1986/brandb97/fix-graph-write-leak-v1
Pull-Request: https://github.com/git/git/pull/1986

 builtin/commit-graph.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index a783a86e797..ee48980248f 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -311,6 +311,7 @@ static int graph_write(int argc, const char **argv, const char *prefix,
 		while (strbuf_getline(&buf, stdin) != EOF) {
 			if (read_one_commit(&commits, progress, buf.buf)) {
 				result = 1;
+				stop_progress(&progress);
 				goto cleanup;
 			}
 		}

base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67

-- 
gitgitgadget