git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] refs: exit early from the loop if it is not a main worktree

From
AGAreaZR via GitGitGadget <gitgitgadget@gmail.com>
Date
Dec 18, 2024, 02:20 UTC
Message-ID
<pull.1848.git.git.1734488445457.gitgitgadget@gmail.com>
From: Seija Kijin <doremylover123@gmail.com>

The is_main_worktree function just checks for !wt->id, but the compiler doesn't know this as it is in a different file, so just exit out early.

Signed-off-by: Seija Kijin <doremylover123@gmail.com>
---
    refs: exit early from the loop if it is not a main worktree
    
    The is_main_worktree function just checks for !wt->id, but the compiler
    doesn't know this as it is in a different file, so just exit out early.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1848%2FAreaZR%2Fexit-early-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1848/AreaZR/exit-early-v1
Pull-Request: https://github.com/git/git/pull/1848
 refs.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/refs.c b/refs.c
index 8b713692359..cce63a618d7 100644
--- a/refs.c
+++ b/refs.c
@@ -2791,6 +2791,7 @@ static int has_worktrees(void)
 		if (is_main_worktree(worktrees[i]))
 			continue;
 		ret = 1;
+		break;
 	}
 
 	free_worktrees(worktrees);

base-commit: 063bcebf0c917140ca0e705cbe0fdea127e90086
-- 
gitgitgadget
Next: shejialuo
Message 1 of 8 in “refs: exit early from the loop if it is not a main worktree”
  1. refs: exit early from the loop if it is not a main worktreeAreaZR via GitGitGadget, Dec 18, 2024
  2. shejialuoDec 18, 2024
  3. Eric SunshineDec 18, 2024
  4. Junio C HamanoDec 19, 2024
  5. Eric SunshineDec 19, 2024
  6. Junio C HamanoDec 19, 2024
  7. Patrick SteinhardtDec 27, 2024
  8. Patrick SteinhardtDec 27, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.