git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] refs/files: prevent memory leak by freeing packed_ref_store

From
SGSven Strickroth via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 5, 2024, 09:53 UTC
Message-ID
<pull.1757.v2.git.git.1722851612505.gitgitgadget@gmail.com>
In-Reply-To
<pull.1757.git.git.1722681471550.gitgitgadget@gmail.com>
From: Sven Strickroth <email@cs-ware.de>

This complements 64a6dd8ffc (refs: implement removal of ref storages, 2024-06-06).

Signed-off-by: Sven Strickroth <email@cs-ware.de>
---
    refs/files: prevent memory leak by freeing packed_ref_store
    
    This complements "refs: implement removal of ref storages"
    (64a6dd8ffc2f).
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1757%2Fcsware%2Frefs-files-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1757/csware/refs-files-v2
Pull-Request: https://github.com/git/git/pull/1757
Range-diff vs v1:
 1:  c68d0de3d58 ! 1:  96018e7257c refs/files: prevent memory leak by freeing packed_ref_store
     @@ Metadata
       ## Commit message ##
          refs/files: prevent memory leak by freeing packed_ref_store
      
     -    This complements "refs: implement removal of ref storages" (64a6dd8ffc2f).
     +    This complements 64a6dd8ffc (refs: implement removal of ref storages,
     +    2024-06-06).
      
          Signed-off-by: Sven Strickroth <email@cs-ware.de>
      
 refs/files-backend.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/refs/files-backend.c b/refs/files-backend.c
index aa52d9be7c7..11551de8f84 100644
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -157,6 +157,7 @@ static void files_ref_store_release(struct ref_store *ref_store)
 	free_ref_cache(refs->loose);
 	free(refs->gitcommondir);
 	ref_store_release(refs->packed_ref_store);
+	free(refs->packed_ref_store);
 }
 
 static void files_reflog_path(struct files_ref_store *refs,

base-commit: e559c4bf1a306cf5814418d318cc0fea070da3c7
-- 
gitgitgadget
Previous: Sven StrickrothNext: Patrick Steinhardt
Message 4 of 6 in “refs/files: prevent memory leak by freeing packed_ref_store”
  1. refs/files: prevent memory leak by freeing packed_ref_storeSven Strickroth via GitGitGadget, Aug 3, 2024
  2. Patrick SteinhardtAug 5, 2024
  3. Sven StrickrothAug 5, 2024
  4. refs/files: prevent memory leak by freeing packed_ref_storeSven Strickroth via GitGitGadget, Aug 5, 2024
  5. Patrick SteinhardtAug 5, 2024
  6. Junio C HamanoAug 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.