git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] utf8: change return type of some helpers from int to size_t

From
Mohit Marathe via GitGitGadget <gitgitgadget@gmail.com>
Date
Mar 17, 2024, 08:27 UTC
Message-ID
<pull.1690.git.1710664071.gitgitgadget@gmail.com>
Hello,

There are lot of places in the codebase where int is used to store size of an object instead of size_t (which is better alternative due to reasons like portability, readability, etc). This patch series accomplishes one such #TODO comment, which addresses this issue.

I appreciate your review and feedback on this patch series.
Best regards, Mohit Marathe
Mohit Marathe (2):
  utf8: change type from int to size_t
  utf8: make utf8_strnwidth & utf8_strwidth return size_t instead of int
 builtin/blame.c    |  6 +++---
 builtin/branch.c   |  2 +-
 builtin/fetch.c    |  2 +-
 builtin/worktree.c |  4 ++--
 column.c           |  2 +-
 diff.c             |  8 +++++---
 gettext.c          |  2 +-
 gettext.h          |  2 +-
 pretty.c           |  4 ++--
 utf8.c             | 14 +++++---------
 utf8.h             |  4 ++--
 wt-status.c        |  4 ++--
 12 files changed, 26 insertions(+), 28 deletions(-)
base-commit: 2953d95d402b6bff1a59c4712f4d46f1b9ea137f
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1690%2Fmohit-marathe%2Fint-to-size_t-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1690/mohit-marathe/int-to-size_t-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1690
-- 
gitgitgadget
Next: Mohit Marathe via GitGitGadget
Message 1 of 6 in “utf8: change return type of some helpers from int to size_t”
  1. 0/2 utf8: change return type of some helpers from int to size_tMohit Marathe via GitGitGadget, Mar 17, 2024
  2. 1/2 utf8: change type from int to size_tMohit Marathe via GitGitGadget, Mar 17, 2024
  3. Patrick SteinhardtMar 21, 2024
  4. 2/2 utf8: make utf8_strnwidth & utf8_strwidth return size_t instead of intMohit Marathe via GitGitGadget, Mar 17, 2024
  5. Junio C HamanoMar 17, 2024
  6. Patrick SteinhardtMar 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.