git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/lib-credential: clean additional credential

From
Bo Anderson via GitGitGadget <gitgitgadget@gmail.com>
Date
Feb 15, 2024, 01:03 UTC
Message-ID
<pull.1664.git.1707959036807.gitgitgadget@gmail.com>
From: Bo Anderson <mail@boanderson.me>

71201ab0e5 (t/lib-credential.sh: ensure credential helpers handle long headers, 2023-05-01) added a test which stores credentials with the host victim.example.com but this was never cleaned up, leaving residual data in the credential store after running the tests.

Add a cleanup call for this credential to resolve this issue.
Signed-off-by: Bo Anderson <mail@boanderson.me>
---
    t/lib-credential: clean additional credential
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1664%2FBo98%2Ft-credential-missing-clean-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1664/Bo98/t-credential-missing-clean-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1664
 t/lib-credential.sh | 1 +
 1 file changed, 1 insertion(+)
diff --git a/t/lib-credential.sh b/t/lib-credential.sh
index 15fc9a31e2c..44799c0d38f 100644
--- a/t/lib-credential.sh
+++ b/t/lib-credential.sh
@@ -50,6 +50,7 @@ helper_test_clean() {
 	reject $1 https example.com user-overwrite
 	reject $1 https example.com user-erase1
 	reject $1 https example.com user-erase2
+	reject $1 https victim.example.com user
 	reject $1 http path.tld user
 	reject $1 https timeout.tld user
 	reject $1 https sso.tld

base-commit: efb050becb6bc703f76382e1f1b6273100e6ace3
-- 
gitgitgadget
Next: Jeff King
Message 1 of 4 in “t/lib-credential: clean additional credential”
  1. t/lib-credential: clean additional credentialBo Anderson via GitGitGadget, Feb 15, 2024
  2. Jeff KingFeb 15, 2024
  3. Junio C HamanoFeb 15, 2024
  4. t0303: check that helper_test_clean removes all credentialsJeff King, Feb 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.