git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Fix a typo in `each_file_in_pack_dir_fn()`'s declaration

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 17, 2023, 13:15 UTC
Message-ID
<pull.1614.git.1700226915859.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

One parameter is called `file_pach`. On the face of it, this looks as if it was supposed to talk about a `path` instead of a `pach`.

However, looking at the way this callback is called, it gets fed the `d_name` from a directory entry, which provides just the file name, not the full path. Therefore, let's fix this by calling the parameter `file_name` instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    packfile.h: fix a typo
    
    I stumbled over this typo yesterday. Nothing about this patch is urgent,
    of course, it can easily wait until v2.43.0 is released.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1614%2Fdscho%2Fpackfile.h-typo-fix-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1614/dscho/packfile.h-typo-fix-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1614
 packfile.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/packfile.h b/packfile.h
index c3692308b8d..28c8fd3e39a 100644
--- a/packfile.h
+++ b/packfile.h
@@ -54,7 +54,7 @@ const char *pack_basename(struct packed_git *p);
 struct packed_git *parse_pack_index(unsigned char *sha1, const char *idx_path);
 
 typedef void each_file_in_pack_dir_fn(const char *full_path, size_t full_path_len,
-				      const char *file_pach, void *data);
+				      const char *file_name, void *data);
 void for_each_file_in_pack_dir(const char *objdir,
 			       each_file_in_pack_dir_fn fn,
 			       void *data);

base-commit: cfb8a6e9a93adbe81efca66e6110c9b4d2e57169
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 2 in “Fix a typo in `each_file_in_pack_dir_fn()`'s declaration”
  1. Fix a typo in `each_file_in_pack_dir_fn()`'s declarationJohannes Schindelin via GitGitGadget, Nov 17, 2023
  2. Junio C HamanoNov 19, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.