git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] strvec: drop unnecessary include of hex.h

From
LGLinus Arver via GitGitGadget <gitgitgadget@gmail.com>
Date
Nov 2, 2023, 20:51 UTC
Message-ID
<pull.1608.git.1698958277454.gitgitgadget@gmail.com>
From: Linus Arver <linusa@google.com>

In 41771fa435 (cache.h: remove dependence on hex.h; make other files include it explicitly, 2023-02-24) we added this as part of a larger mechanical refactor. But strvec doesn't actually depend on hex.h, so remove it.

Signed-off-by: Linus Arver <linusa@google.com>
---
    strvec: drop unnecessary include of hex.h
    
    In 41771fa435 (cache.h: remove dependence on hex.h; make other files
    include it explicitly, 2023-02-24) we added this as part of a larger
    mechanical refactor. But strvec doesn't actually depend on hex.h, so
    remove it.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1608
 strvec.c | 1 -
 1 file changed, 1 deletion(-)
diff --git a/strvec.c b/strvec.c
index 89dc9e7e753..178f4f37480 100644
--- a/strvec.c
+++ b/strvec.c
@@ -1,6 +1,5 @@
 #include "git-compat-util.h"
 #include "strvec.h"
-#include "hex.h"
 #include "strbuf.h"
 
 const char *empty_strvec[] = { NULL };

base-commit: bc5204569f7db44d22477485afd52ea410d83743
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 2 in “strvec: drop unnecessary include of hex.h”
  1. strvec: drop unnecessary include of hex.hLinus Arver via GitGitGadget, Nov 2, 2023
  2. Junio C HamanoNov 2, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.