git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] Fix two rebase bugs related to total_nr

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
May 10, 2023, 22:55 UTC
Message-ID
<pull.1531.git.1683759338.gitgitgadget@gmail.com>

I recently picked up work where I regularly rebase large branch thickets consisting of thousands of commits. During those rebases, I could not fail to notice that the progress initially showed a total number around 2,100, when the actual number of commands was more like 1,850. And indeed, when resuming the rebase after being interrupted due to a break command or due to a merge conflict, the progress showed the correct number!

So I set out to fix this, stumbling over an incorrect use of total_nr in the --update-refs code, so I fixed that, too.

Note: These patches apply cleanly on top of ds/rebase-update-ref as well as
on top of the current main branch.
Johannes Schindelin (2):
  rebase --update-refs: fix loops
  rebase -r: fix the total number shown in the progress
 sequencer.c              | 16 ++++++++++------
 t/t3430-rebase-merges.sh |  7 +++++++
 2 files changed, 17 insertions(+), 6 deletions(-)
base-commit: 4611884ea883908a9638cafbd824c401c41cf7f6
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1531%2Fdscho%2Ffix-rebase-i-progress-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1531/dscho/fix-rebase-i-progress-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1531
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 11 in “Fix two rebase bugs related to total_nr”
  1. 0/2 Fix two rebase bugs related to total_nrJohannes Schindelin via GitGitGadget, May 10, 2023
  2. 1/2 rebase --update-refs: fix loopsJohannes Schindelin via GitGitGadget, May 10, 2023
  3. Junio C HamanoMay 10, 2023
  4. 2/2 rebase -r: fix the total number shown in the progressJohannes Schindelin via GitGitGadget, May 10, 2023
  5. Junio C HamanoMay 10, 2023
  6. Phillip WoodMay 11, 2023
  7. Junio C HamanoMay 11, 2023
  8. 0/2 Fix two rebase bugs related to total_nrJohannes Schindelin via GitGitGadget, May 13, 2023
  9. 1/2 rebase --update-refs: fix loopsJohannes Schindelin via GitGitGadget, May 13, 2023
  10. 2/2 rebase -r: fix the total number shown in the progressJohannes Schindelin via GitGitGadget, May 13, 2023
  11. Phillip WoodMay 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.