git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/2] ci: fix the FreeBSD build

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Jul 29, 2022, 12:28 UTC
Message-ID
<pull.1308.git.1659097724.gitgitgadget@gmail.com>

Since 3a251bac0d1a (trace2: only include "fsync" events if we git_fsync(), 2022-07-18), the FreeBSD builds are failing in t5351.6. See https://cirrus-ci.com/task/4577761405698048 for an example. The run at https://cirrus-ci.com/task/6004115347079168 shows that this patch fixes the bug.

While verifying the fix on Windows, I noticed a recent, rather terrible performance regression: t5351 all of a sudden takes almost half an hour [https://github.com/git/git/runs/7398490747?check_suite_focus=true#step:5:171] to run on Windows. I found a fix, and it now passes in less than half a minute [https://github.com/gitgitgadget/git/runs/7578071365?check_suite_focus=true#step:5:125] again.

Johannes Schindelin (2):
  t5351: avoid relying on `core.fsyncMethod = batch` to be supported
  t5351: avoid using `test_cmp` for binary data
 bulk-checkin.c                  |  2 ++
 t/t5351-unpack-large-objects.sh | 12 +++++++++---
 2 files changed, 11 insertions(+), 3 deletions(-)
base-commit: 23b219f8e3f2adfb0441e135f0a880e6124f766c
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1308%2Fdscho%2Ffix-t5351-on-freebsd-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1308/dscho/fix-t5351-on-freebsd-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1308
-- 
gitgitgadget
Next: Johannes Schindelin via GitGitGadget
Message 1 of 8 in “ci: fix the FreeBSD build”
  1. 0/2 ci: fix the FreeBSD buildJohannes Schindelin via GitGitGadget, Jul 29, 2022
  2. 1/2 t5351: avoid relying on `core.fsyncMethod = batch` to be supportedJohannes Schindelin via GitGitGadget, Jul 29, 2022
  3. Junio C HamanoJul 29, 2022
  4. brian m. carlsonJul 29, 2022
  5. 2/2 t5351: avoid using `test_cmp` for binary dataJohannes Schindelin via GitGitGadget, Jul 29, 2022
  6. Derrick StoleeJul 29, 2022
  7. Carlo Marcelo Arenas BelónJul 29, 2022
  8. Junio C HamanoJul 29, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.