git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Documentation/git-reflog: remove unneeded \ from \{

From
Glen Choo via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 1, 2022, 21:04 UTC
Message-ID
<pull.1304.git.git.1659387885711.gitgitgadget@gmail.com>
From: Glen Choo <chooglen@google.com>

There are some inconsistencies with how different asciidoc environments handle different combinations of "\{<>}", e.g. these results were observed with asciidoc on two different environments:

  | Input     | Output (env A) | Output (env B)   | same/different |
  |-----------+----------------+------------------+----------------|
  | \{<foo>\} | {&lt;foo&gt;}  | \{&lt;foo&gt;}^M | different      |
  | {<foo>}   | {&lt;foo&gt;}  | {&lt;foo&gt;}    | same           |
  | \{<foo>}  | {&lt;foo&gt;}  | \{&lt;foo&gt;}^M | different      |
  | \{foo\}   | {foo}          | {foo}            | same           |
  | \{\}      | {}             | \{}^M            | different      |
  | \{}       | {}             | {}               | same           |
  | {\}       | {}             | {}               | same           |

The only instance of this biting us is "@\{<specifier>\}" in Documentation/git-reflog.txt; all other combinations of "\{<>}" (e.g. in Documentation/revisions.txt) seem to render consistently.

Fix this inconsistent rendering by removing the unnecessary "\" in Documentation/git-reflog.txt.

Signed-off-by: Glen Choo <chooglen@google.com>
---
    Documentation/git-reflog: remove unneeded \ from {
    
    I noticed this inconsistency as I was trying to build Git docs with
    Google's internal build system. This string seems particularly
    problematic e.g. you can see unnecessary "\" on
    https://git-scm.com/docs/git-reflog#_description.
    
    I'm not proficient in asciidoc at all, but I suspect that this isn't
    tied to the asciidoc version; I initially observed these differences in
    environments with different versions of asciidoc (9.0.0 and 10.2.0) but
    I can't reproduce this at all on my Mac using different versions of
    asciidoc and asciidoctor from Homebrew. Perhaps the issue is in some
    underlying library?
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1304%2Fchooglen%2Fdocumentation%2Fbackslash-brace-asciidoc-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1304/chooglen/documentation/backslash-brace-asciidoc-v1
Pull-Request: https://github.com/git/git/pull/1304
 Documentation/git-reflog.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt
index 5ced7ad4f8b..db9d46edfa9 100644
--- a/Documentation/git-reflog.txt
+++ b/Documentation/git-reflog.txt
@@ -22,7 +22,7 @@ depending on the subcommand:
 	[--rewrite] [--updateref] [--stale-fix]
 	[--dry-run | -n] [--verbose] [--all [--single-worktree] | <refs>...]
 'git reflog delete' [--rewrite] [--updateref]
-	[--dry-run | -n] [--verbose] <ref>@\{<specifier>\}...
+	[--dry-run | -n] [--verbose] <ref>@{<specifier>}...
 'git reflog exists' <ref>
 
 Reference logs, or "reflogs", record when the tips of branches and

base-commit: 23b219f8e3f2adfb0441e135f0a880e6124f766c
-- 
gitgitgadget
Next: Junio C Hamano
Message 1 of 5 in “Documentation/git-reflog: remove unneeded \ from \{”
  1. Documentation/git-reflog: remove unneeded \ from \{Glen Choo via GitGitGadget, Aug 1, 2022
  2. Junio C HamanoAug 1, 2022
  3. Johannes SchindelinAug 10, 2022
  4. Felipe ContrerasAug 10, 2022
  5. Glen ChooAug 10, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.