git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 0/8] [GSOC] [RFC] ref-filter: code logic optimization

From
ZheNing Hu via GitGitGadget <gitgitgadget@gmail.com>
Date
Aug 17, 2021, 08:41 UTC
Message-ID
<pull.1021.git.1629189701.gitgitgadget@gmail.com>

Last time I submitted a very long patch series: https://lore.kernel.org/git/pull.1016.git.1628842990.gitgitgadget@gmail.com/ My mentor Christian suggested to split the performance optimization part out, so this patch series used to optimize code logic in ref-filter.

Changes in this patch series:
 1. Remove grab_oid to reduce unnecessary string comparison.
 2. Use atom_type in grab_person() and merge the two for loops.
 3. Remove strlen() and introducing xstrvfmt_len() and xstrfmt_len() to
    reduce strlen() overhead.
 4. Introduction ref_filter_slopbuf[1] to reduce memory allocation.
 5. Add deref to struct used_atom to increase the readability of the code.
 6. Introduction symref_atom_parser() to increase the readability of the
    code.
 7. Use switch/case instread of if/else to increase the readability of the
    code.
ZheNing Hu (8):
  [GSOC] ref-filter: remove grab_oid() function
  [GSOC] ref-filter: merge two for loop in grab_person
  [GSOC] ref-filter: remove strlen from find_subpos
  [GSOC] ref-filter: introducing xstrvfmt_len() and xstrfmt_len()
  [GSOC] ref-filter: introduction ref_filter_slopbuf[1]
  [GSOC] ref-filter: add deref member to struct used_atom
  [GSOC] ref-filter: introduce symref_atom_parser()
  [GSOC] ref-filter: use switch/case instead of if/else
 ref-filter.c | 432 ++++++++++++++++++++++++++++-----------------------
 1 file changed, 237 insertions(+), 195 deletions(-)
base-commit: f000ecbed922c727382651490e75014f003c89ca
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1021%2Fadlternative%2Fref-filter-opt-code-logic-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1021/adlternative/ref-filter-opt-code-logic-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1021
-- 
gitgitgadget
Next: ZheNing Hu via GitGitGadget
Message 1 of 9 in “[GSOC] [RFC] ref-filter: code logic optimization”
  1. 0/8 [GSOC] [RFC] ref-filter: code logic optimizationZheNing Hu via GitGitGadget, Aug 17, 2021
  2. 1/8 [GSOC] ref-filter: remove grab_oid() functionZheNing Hu via GitGitGadget, Aug 17, 2021
  3. 2/8 [GSOC] ref-filter: merge two for loop in grab_personZheNing Hu via GitGitGadget, Aug 17, 2021
  4. 3/8 [GSOC] ref-filter: remove strlen from find_subposZheNing Hu via GitGitGadget, Aug 17, 2021
  5. 4/8 [GSOC] ref-filter: introducing xstrvfmt_len() and xstrfmt_len()ZheNing Hu via GitGitGadget, Aug 17, 2021
  6. 5/8 [GSOC] ref-filter: introduction ref_filter_slopbuf[1]ZheNing Hu via GitGitGadget, Aug 17, 2021
  7. 6/8 [GSOC] ref-filter: add deref member to struct used_atomZheNing Hu via GitGitGadget, Aug 17, 2021
  8. 7/8 [GSOC] ref-filter: introduce symref_atom_parser()ZheNing Hu via GitGitGadget, Aug 17, 2021
  9. 8/8 [GSOC] ref-filter: use switch/case instead of if/elseZheNing Hu via GitGitGadget, Aug 17, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.