[PATCH v3 7/8] Makefile: build 'gitweb' in the default target
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 28, 2022, 10:16 UTC
- Message-ID
- <patch-v3-7.8-571c9c10319-20220628T100936Z-avarab@gmail.com>
- In-Reply-To
- <cover-v3-0.8-00000000000-20220628T100936Z-avarab@gmail.com>
From: SZEDER Gábor <szeder.dev@gmail.com>
Our Makefile's default target used to build 'gitweb', though indirectly: the 'all' target depended on 'git-instaweb', which in turn depended on 'gitweb'. Then e25c7cc146 (Makefile: drop dependency between git-instaweb and gitweb, 2015-05-29) removed the latter dependency, and for good reasons (quoting its commit message):
"1. git-instaweb has no build-time dependency on gitweb; it
is a run-time dependency 2. gitweb is a directory that we want to recursively make
in. As a result, its recipe is marked .PHONY, which
causes "make" to rebuild git-instaweb every time it is
run."Since then a simple 'make' doesn't build 'gitweb'.
Luckily, installing 'gitweb' is not broken: although 'make install' doesn't depend on the 'gitweb' target, it has a dependency on the 'install-gitweb' target, which does generate all the necessary files for 'gitweb' and installs them. However, if someone runs 'make && sudo make install', then those files in the 'gitweb' directory will be generated and owned by root, which is not nice.
List 'gitweb' as a direct dependency of the default target, so a plain 'make' will build it.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Makefile | 1 + 1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile index a5f29c11681..d150be4dc32 100644 --- a/Makefile +++ b/Makefile @@ -3155,6 +3155,7 @@ include gitweb/Makefile .PHONY: gitweb gitweb: $(MAK_DIR_GITWEB_ALL) +all:: gitweb ### Installation rules
-- 2.37.0.880.gf07d56b18ba