[PATCH v2 02/11] clone: fix memory leak in wanted_peer_refs()
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jul 1, 2022, 10:42 UTC
- Message-ID
- <patch-v2-02.11-24a1eaa51a3-20220701T104017Z-avarab@gmail.com>
- In-Reply-To
- <cover-v2-00.11-00000000000-20220701T104017Z-avarab@gmail.com>
Fix a memory leak added in 0ec4b1650cc (clone: fix ref selection in --single-branch --branch=xxx, 2012-06-22).
Whether we get our "remote_head" from copy_ref() directly, or with a call to guess_remote_head() it'll be the result of a copy_ref() in either case, as guess_remote_head() is a wrapper for copy_ref() (or it returns NULL).
We can't mark any tests passing passing with SANITIZE=leak using "TEST_PASSES_SANITIZE_LEAK=true" as a result of this change, but e.g. "t/t1500-rev-parse.sh" now gets closer to passing.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/clone.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/builtin/clone.c b/builtin/clone.c index 89a91b00177..c43c85dad07 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -494,6 +494,7 @@ static struct ref *wanted_peer_refs(const struct ref *refs, /* if --branch=tag, pull the requested tag explicitly */ get_fetch_map(remote_head, tag_refspec, &tail, 0); } + free_refs(remote_head); } else { int i; for (i = 0; i < refspec->nr; i++)
-- 2.37.0.900.g4d0de1cceb2