git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 5/5] advice.[ch]: sort enum fields in alphabetical order

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 4, 2021, 01:58 UTC
Message-ID
<patch-5.5-171153d421e-20211004T015432Z-avarab@gmail.com>
In-Reply-To
<cover-0.5-00000000000-20211004T015432Z-avarab@gmail.com>
These fields have slightly drifted out of order, let's re-order them.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 advice.c | 2 +-
 advice.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/advice.c b/advice.c
index f7cedac7549..e0ee8ca4f2f 100644
--- a/advice.c
+++ b/advice.c
@@ -51,9 +51,9 @@ static struct {
 	[ADVICE_PUSH_ALREADY_EXISTS]			= { "advice.pushAlreadyExists" },
 	[ADVICE_PUSH_FETCH_FIRST]			= { "advice.pushFetchFirst" },
 	[ADVICE_PUSH_NEEDS_FORCE]			= { "advice.pushNeedsForce" },
-	[ADVICE_PUSH_REF_NEEDS_UPDATE]			= { "advice.pushRefNeedsUpdate" },
 	[ADVICE_PUSH_NON_FF_CURRENT]			= { "advice.pushNonFFCurrent" },
 	[ADVICE_PUSH_NON_FF_MATCHING]			= { "advice.pushNonFFMatching" },
+	[ADVICE_PUSH_REF_NEEDS_UPDATE]			= { "advice.pushRefNeedsUpdate" },
 	[ADVICE_PUSH_UNQUALIFIED_REF_NAME]		= { "advice.pushUnqualifiedRefName" },
 	[ADVICE_PUSH_UPDATE_REJECTED]			= { "advice.pushUpdateRejected" },
 	[ADVICE_RESET_QUIET_WARNING]			= { "advice.resetQuiet" },
diff --git a/advice.h b/advice.h
index ab25c6ba9a0..a6aca9684c7 100644
--- a/advice.h
+++ b/advice.h
@@ -31,9 +31,9 @@ enum advice_type {
 	ADVICE_PUSH_NEEDS_FORCE,
 	ADVICE_PUSH_NON_FF_CURRENT,
 	ADVICE_PUSH_NON_FF_MATCHING,
+	ADVICE_PUSH_REF_NEEDS_UPDATE,
 	ADVICE_PUSH_UNQUALIFIED_REF_NAME,
 	ADVICE_PUSH_UPDATE_REJECTED,
-	ADVICE_PUSH_REF_NEEDS_UPDATE,
 	ADVICE_RESET_QUIET_WARNING,
 	ADVICE_RESOLVE_CONFLICT,
 	ADVICE_RM_HINTS,
-- 
2.33.0.1404.g7bcfc82b295
Previous: Ævar Arnfjörð Bjarmason
Message 6 of 6 in “advice API: simplification, small fixes, readability”
  1. 0/5 advice API: simplification, small fixes, readabilityÆvar Arnfjörð Bjarmason, Oct 4, 2021
  2. 2/5 advice output: emit empty lines as "hint:", not "hint: "Ævar Arnfjörð Bjarmason, Oct 4, 2021
  3. 1/5 advice.h: don't indent top-level enumÆvar Arnfjörð Bjarmason, Oct 4, 2021
  4. 3/5 advice.[ch]: remove advice.pushNonFastForward aliasÆvar Arnfjörð Bjarmason, Oct 4, 2021
  5. 4/5 advice API: revamp the API, againÆvar Arnfjörð Bjarmason, Oct 4, 2021
  6. 5/5 advice.[ch]: sort enum fields in alphabetical orderÆvar Arnfjörð Bjarmason, Oct 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.