git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/8] reflog: refactor cmd_reflog() to "if" branches

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 17, 2022, 18:08 UTC
Message-ID
<patch-2.8-8bff6976334-20220317T180439Z-avarab@gmail.com>
In-Reply-To
<cover-0.8-00000000000-20220317T180439Z-avarab@gmail.com>

Refactor the "if" branches in cmd_reflog() to use "else if" instead, and remove the whitespace between them.

As with 92f480909f7 (multi-pack-index: refactor "goto usage" pattern, 2021-08-23) this makes this code more consistent with how builtin/{bundle,stash,commit-graph,multi-pack-index}.c look and behave. Their top-level commands are all similar sub-command routing functions.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/reflog.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/builtin/reflog.c b/builtin/reflog.c
index 9407f835cb6..c864f276308 100644
--- a/builtin/reflog.c
+++ b/builtin/reflog.c
@@ -384,14 +384,11 @@ int cmd_reflog(int argc, const char **argv, const char *prefix)
 
 	if (!strcmp(argv[1], "show"))
 		return cmd_log_reflog(argc - 1, argv + 1, prefix);
-
-	if (!strcmp(argv[1], "expire"))
+	else if (!strcmp(argv[1], "expire"))
 		return cmd_reflog_expire(argc - 1, argv + 1, prefix);
-
-	if (!strcmp(argv[1], "delete"))
+	else if (!strcmp(argv[1], "delete"))
 		return cmd_reflog_delete(argc - 1, argv + 1, prefix);
-
-	if (!strcmp(argv[1], "exists"))
+	else if (!strcmp(argv[1], "exists"))
 		return cmd_reflog_exists(argc - 1, argv + 1, prefix);
 
 	return cmd_log_reflog(argc, argv, prefix);
-- 
2.35.1.1384.g7d2906948a1
Previous: John CaiNext: Ævar Arnfjörð Bjarmason
Message 4 of 15 in “reflog: migrate fully to parse_options()”
  1. 0/8 reflog: migrate fully to parse_options()Ævar Arnfjörð Bjarmason, Mar 17, 2022
  2. 1/8 reflog.c: indent argument listsÆvar Arnfjörð Bjarmason, Mar 17, 2022
  3. John CaiMar 17, 2022
  4. 2/8 reflog: refactor cmd_reflog() to "if" branchesÆvar Arnfjörð Bjarmason, Mar 17, 2022
  5. 3/8 reflog tests: add missing "git reflog exists" testsÆvar Arnfjörð Bjarmason, Mar 17, 2022
  6. 4/8 reflog: move "usage" variables and use macrosÆvar Arnfjörð Bjarmason, Mar 17, 2022
  7. 5/8 git reflog [expire|delete]: make -h output consistent with SYNOPSISÆvar Arnfjörð Bjarmason, Mar 17, 2022
  8. Junio C HamanoMar 18, 2022
  9. 6/8 reflog exists: use parse_options() APIÆvar Arnfjörð Bjarmason, Mar 17, 2022
  10. Junio C HamanoMar 18, 2022
  11. 7/8 reflog: convert to parse_options() APIÆvar Arnfjörð Bjarmason, Mar 17, 2022
  12. Junio C HamanoMar 18, 2022
  13. 8/8 reflog [show]: display sensible -h outputÆvar Arnfjörð Bjarmason, Mar 17, 2022
  14. reflog: fix 'show' subcommand's argvSZEDER Gábor, Mar 28, 2022
  15. Junio C HamanoMar 28, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.