[PATCH v3 2/6] commit-graph: remove redundant handling of -h
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jul 20, 2021, 11:39 UTC
- Message-ID
- <patch-2.6-8f50750ae5e-20210720T113707Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.6-00000000000-20210720T113707Z-avarab@gmail.com>
If we don't handle the -h option here like most parse_options() users we'll fall through and it'll do the right thing for us.
I think this code added in 4ce58ee38d (commit-graph: create git-commit-graph builtin, 2018-04-02) was always redundant, parse_options() did this at the time, and the commit-graph code never used PARSE_OPT_NO_INTERNAL_HELP.
We don't need a test for this, it's tested by the t0012-help.sh test added in d691551192a (t0012: test "-h" with builtins, 2017-05-30).
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/commit-graph.c | 4 ---- 1 file changed, 4 deletions(-)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c index 5af3cd7178f..3cf18dc5345 100644 --- a/builtin/commit-graph.c +++ b/builtin/commit-graph.c @@ -321,10 +321,6 @@ int cmd_commit_graph(int argc, const char **argv, const char *prefix) OPT_END(), }; - if (argc == 2 && !strcmp(argv[1], "-h")) - usage_with_options(builtin_commit_graph_usage, - builtin_commit_graph_options); - git_config(git_default_config, NULL); argc = parse_options(argc, argv, prefix, builtin_commit_graph_options,
-- 2.32.0.874.ge7a9d58bfcf