[PATCH v2 2/6] mktag tests: invert --no-strict test
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 17, 2021, 10:41 UTC
- Message-ID
- <patch-2.6-550dcedfcb-20210617T104011Z-avarab@gmail.com>
- In-Reply-To
- <cover-0.6-0000000000-20210617T104011Z-avarab@gmail.com>
Change the mktag --no-strict test to actually test success under --no-strict, that test was added in 06ce79152be (mktag: add a --[no-]strict option, 2021-01-06).
It doesn't make sense to check that we have the same failure except when we want --no-strict, by doing that we're assuming that the behavior will be different under --no-strict, bun nothing was testing for that.
We should instead assert that --strict is the same as --no-strict, except in the cases where we've declared that it's not.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- t/t3800-mktag.sh | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index e9008744e3..951e6d39c2 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh @@ -33,6 +33,8 @@ check_verify_failure () { then test_must_fail git mktag <tag.sig 2>err2 && test_cmp err err2 + else + git mktag --no-strict <tag.sig fi ' }
-- 2.32.0.571.gdba276db2c