git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 12/12] misc *.c: use designated initializers for "partial" struct assignments

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 24, 2022, 09:33 UTC
Message-ID
<patch-12.12-d39622453d4-20220224T092805Z-avarab@gmail.com>
In-Reply-To
<cover-00.12-00000000000-20220224T092805Z-avarab@gmail.com>

Change a few existing non-designated initializer assignments to use "partial" designated initializer assignments. I.e. we're now omitting the "NULL" or "0" fields and letting the initializer take care of them for us.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/fast-import.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/builtin/fast-import.c b/builtin/fast-import.c
index 2b2e28bad79..2c244c68f7e 100644
--- a/builtin/fast-import.c
+++ b/builtin/fast-import.c
@@ -176,8 +176,9 @@ static int global_argc;
 static const char **global_argv;
 
 /* Memory pools */
-static struct mem_pool fi_mem_pool =  {NULL, 2*1024*1024 -
-				       sizeof(struct mp_block), 0 };
+static struct mem_pool fi_mem_pool = {
+	.block_alloc = 2*1024*1024 - sizeof(struct mp_block),
+};
 
 /* Atom management */
 static unsigned int atom_table_sz = 4451;
@@ -205,7 +206,9 @@ static int import_marks_file_done;
 static int relative_marks_paths;
 
 /* Our last blob */
-static struct last_object last_blob = { STRBUF_INIT, 0, 0, 0 };
+static struct last_object last_blob = {
+	.data = STRBUF_INIT,
+ };
 
 /* Tree management */
 static unsigned int tree_entry_alloc = 1000;
@@ -231,7 +234,10 @@ static struct tag *last_tag;
 static whenspec_type whenspec = WHENSPEC_RAW;
 static struct strbuf command_buf = STRBUF_INIT;
 static int unread_command_buf;
-static struct recent_command cmd_hist = {&cmd_hist, &cmd_hist, NULL};
+static struct recent_command cmd_hist = {
+	.prev = &cmd_hist,
+	.next = &cmd_hist,
+};
 static struct recent_command *cmd_tail = &cmd_hist;
 static struct recent_command *rc_free;
 static unsigned int cmd_save = 100;
-- 
2.35.1.1157.g524e2d5a0db
Previous: Ævar Arnfjörð BjarmasonNext: Johannes Schindelin
Message 13 of 17 in “c99: use more designated initializers”
  1. 00/12 c99: use more designated initializersÆvar Arnfjörð Bjarmason, Feb 24, 2022
  2. 01/12 imap-send.c: use designated initializers for "struct imap_server_conf"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  3. 02/12 refs: use designated initializers for "struct ref_storage_be"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  4. 03/12 refs: use designated initializers for "struct ref_iterator_vtable"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  5. 04/12 trace2: use designated initializers for "struct tr2_tgt"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  6. 05/12 trace2: use designated initializers for "struct tr2_dst"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  7. 06/12 object-file: use designated initializers for "struct git_hash_algo"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  8. 07/12 archive-*.c: use designated initializers for "struct archiver"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  9. 08/12 userdiff.c: use designated initializers for "struct userdiff_driver"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  10. 09/12 convert.c: use designated initializers for "struct stream_filter*"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  11. 10/12 refspec.c: use designated initializers for "struct refspec_item"Ævar Arnfjörð Bjarmason, Feb 24, 2022
  12. 11/12 misc *.c: use designated initializers for struct assignmentsÆvar Arnfjörð Bjarmason, Feb 24, 2022
  13. 12/12 misc *.c: use designated initializers for "partial" struct assignmentsÆvar Arnfjörð Bjarmason, Feb 24, 2022
  14. Johannes SchindelinFeb 24, 2022
  15. Junio C HamanoFeb 24, 2022
  16. Ævar Arnfjörð BjarmasonFeb 24, 2022
  17. Junio C HamanoFeb 25, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.