git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/4] doc lint: fix error-hiding regression

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 15, 2021, 12:39 UTC
Message-ID
<patch-1.4-a6461f6e486-20211015T123619Z-avarab@gmail.com>
In-Reply-To
<cover-0.4-00000000000-20211015T123619Z-avarab@gmail.com>

Fix the broken "make lint-docs" (or "make check-docs" at the top-level) target, which has been broken since my cafd9828e89 (doc lint: lint and fix missing "GIT" end sections, 2021-04-09).

The CI for "seen" is emitting an error about a broken gitlink, but due to there being 3x scripts chained via ";" instead of "&&" we're not carrying forward the non-zero exit code.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 Documentation/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/Makefile b/Documentation/Makefile
index f5605b7767f..78324934d9f 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -461,9 +461,9 @@ lint-docs::
 		$(HOWTO_TXT) $(DOC_DEP_TXT) \
 		--section=1 $(MAN1_TXT) \
 		--section=5 $(MAN5_TXT) \
-		--section=7 $(MAN7_TXT); \
-	$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT); \
-	$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT);
+		--section=7 $(MAN7_TXT) && \
+	$(PERL_PATH) lint-man-end-blurb.perl $(MAN_TXT) && \
+	$(PERL_PATH) lint-man-section-order.perl $(MAN_TXT)
 
 ifeq ($(wildcard po/Makefile),po/Makefile)
 doc-l10n install-l10n::
-- 
2.33.1.1338.g20da966911a
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 2 of 8 in “doc lint: fix recent regression, make non-.PHONY”
  1. 0/4 doc lint: fix recent regression, make non-.PHONYÆvar Arnfjörð Bjarmason, Oct 15, 2021
  2. 1/4 doc lint: fix error-hiding regressionÆvar Arnfjörð Bjarmason, Oct 15, 2021
  3. 2/4 doc lint: emit errors on STDERRÆvar Arnfjörð Bjarmason, Oct 15, 2021
  4. 4/4 doc lint: make "lint-docs" non-.PHONYÆvar Arnfjörð Bjarmason, Oct 15, 2021
  5. Bagas SanjayaOct 16, 2021
  6. Ævar Arnfjörð BjarmasonOct 16, 2021
  7. 3/4 doc build: speed up "make lint-docs"Ævar Arnfjörð Bjarmason, Oct 15, 2021
  8. Junio C HamanoOct 15, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.