[PATCH] pre-commit hook tests: don't leave "actual" nonexisting on failure
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jun 14, 2021, 10:37 UTC
- Message-ID
- <patch-1.1-d08a435b8ef-20210614T103654Z-avarab@gmail.com>
Start by creating an "actual" file in a core.hooksPath test that has the hook echoing to the "actual" file.
We later test_cmp that file to see what hooks were run. If we fail to run our hook(s) we'll have an empty list of hooks for the test_cmp instead of a nonexisting file. For the logic of this test that makes more sense.
See 867ad08a261 (hooks: allow customizing where the hook directory is, 2016-05-04) for the commit that added these tests.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> ---
A trivial test improvement split off from v2 of https://lore.kernel.org/git/cover-00.30-00000000000-20210614T101920Z-avarab@gmail.com/
t/t1350-config-hooks-path.sh | 1 + 1 file changed, 1 insertion(+)
diff --git a/t/t1350-config-hooks-path.sh b/t/t1350-config-hooks-path.sh index f1f9aee9f5d..fa9647a7c0b 100755 --- a/t/t1350-config-hooks-path.sh +++ b/t/t1350-config-hooks-path.sh @@ -5,6 +5,7 @@ test_description='Test the core.hooksPath configuration variable' . ./test-lib.sh test_expect_success 'set up a pre-commit hook in core.hooksPath' ' + >actual && mkdir -p .git/custom-hooks .git/hooks && write_script .git/custom-hooks/pre-commit <<-\EOF && echo CUSTOM >>actual
-- 2.32.0.rc3.434.gd8aed1f08a7