git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 09/10] leak tests: mark various "generic" tests as passing with SANITIZE=leak

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Oct 6, 2021, 09:50 UTC
Message-ID
<patch-09.10-9299634b932-20211006T094705Z-avarab@gmail.com>
In-Reply-To
<cover-00.10-00000000000-20211006T094705Z-avarab@gmail.com>

Mark various "generic" tests as passing when git is compiled with SANITIZE=leak. These tests were subjectively picked from the lists of passing tests since they're all small, and test some generic feature such as wildmatch(), commonly used environment variables, ident parsing etc.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 t/t1430-bad-ref-name.sh       | 1 +
 t/t1504-ceiling-dirs.sh       | 2 ++
 t/t1510-repo-setup.sh         | 1 +
 t/t2050-git-dir-relative.sh   | 1 +
 t/t2300-cd-to-toplevel.sh     | 1 +
 t/t3070-wildmatch.sh          | 1 +
 t/t3205-branch-color.sh       | 1 +
 t/t3211-peel-ref.sh           | 1 +
 t/t3300-funny-names.sh        | 1 +
 t/t3902-quoted.sh             | 1 +
 t/t4026-color.sh              | 2 ++
 t/t5580-unc-paths.sh          | 1 +
 t/t5615-alternate-env.sh      | 2 ++
 t/t7518-ident-corner-cases.sh | 2 ++
 14 files changed, 18 insertions(+)
diff --git a/t/t1430-bad-ref-name.sh b/t/t1430-bad-ref-name.sh
index b1839e08771..90b7b350a53 100755
--- a/t/t1430-bad-ref-name.sh
+++ b/t/t1430-bad-ref-name.sh
@@ -4,6 +4,7 @@ test_description='Test handling of ref names that check-ref-format rejects'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success setup '
diff --git a/t/t1504-ceiling-dirs.sh b/t/t1504-ceiling-dirs.sh
index 3d51615e42d..0fafcf9dde3 100755
--- a/t/t1504-ceiling-dirs.sh
+++ b/t/t1504-ceiling-dirs.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='test GIT_CEILING_DIRECTORIES'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_prefix() {
diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
index bbfe05b8e4a..591505a39c0 100755
--- a/t/t1510-repo-setup.sh
+++ b/t/t1510-repo-setup.sh
@@ -43,6 +43,7 @@ A few rules for repo setup:
 # This test heavily relies on the standard error of nested function calls.
 test_untraceable=UnfortunatelyYes
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 here=$(pwd)
diff --git a/t/t2050-git-dir-relative.sh b/t/t2050-git-dir-relative.sh
index 21f4659a9d1..1f193cde965 100755
--- a/t/t2050-git-dir-relative.sh
+++ b/t/t2050-git-dir-relative.sh
@@ -12,6 +12,7 @@ into the subdir while keeping the worktree location,
 and tries commits from the top and the subdir, checking
 that the commit-hook still gets called.'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 COMMIT_FILE="$(pwd)/output"
diff --git a/t/t2300-cd-to-toplevel.sh b/t/t2300-cd-to-toplevel.sh
index c8de6d8a190..b40eeb263fe 100755
--- a/t/t2300-cd-to-toplevel.sh
+++ b/t/t2300-cd-to-toplevel.sh
@@ -2,6 +2,7 @@
 
 test_description='cd_to_toplevel'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 EXEC_PATH="$(git --exec-path)"
diff --git a/t/t3070-wildmatch.sh b/t/t3070-wildmatch.sh
index 56ea4bda133..72d5b014d82 100755
--- a/t/t3070-wildmatch.sh
+++ b/t/t3070-wildmatch.sh
@@ -2,6 +2,7 @@
 
 test_description='wildmatch tests'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 # Disable expensive chain-lint tests; all of the tests in this script
diff --git a/t/t3205-branch-color.sh b/t/t3205-branch-color.sh
index 08bd906173b..6a521c1a3e5 100755
--- a/t/t3205-branch-color.sh
+++ b/t/t3205-branch-color.sh
@@ -4,6 +4,7 @@ test_description='basic branch output coloring'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'set up some sample branches' '
diff --git a/t/t3211-peel-ref.sh b/t/t3211-peel-ref.sh
index 37b9d26f4b6..9cbc34fc583 100755
--- a/t/t3211-peel-ref.sh
+++ b/t/t3211-peel-ref.sh
@@ -4,6 +4,7 @@ test_description='tests for the peel_ref optimization of packed-refs'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 test_expect_success 'create annotated tag in refs/tags' '
diff --git a/t/t3300-funny-names.sh b/t/t3300-funny-names.sh
index f5bf16abcd8..d3ac826283e 100755
--- a/t/t3300-funny-names.sh
+++ b/t/t3300-funny-names.sh
@@ -9,6 +9,7 @@ This test tries pathnames with funny characters in the working
 tree, index, and tree objects.
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 HT='	'
diff --git a/t/t3902-quoted.sh b/t/t3902-quoted.sh
index f528008c363..72a5a565e97 100755
--- a/t/t3902-quoted.sh
+++ b/t/t3902-quoted.sh
@@ -5,6 +5,7 @@
 
 test_description='quoted output'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 FN='濱野'
diff --git a/t/t4026-color.sh b/t/t4026-color.sh
index c0b642c1ab0..cc73161b466 100755
--- a/t/t4026-color.sh
+++ b/t/t4026-color.sh
@@ -4,6 +4,8 @@
 #
 
 test_description='Test diff/status color escape codes'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 ESC=$(printf '\033')
diff --git a/t/t5580-unc-paths.sh b/t/t5580-unc-paths.sh
index cd803ae8bf1..cd7604fff93 100755
--- a/t/t5580-unc-paths.sh
+++ b/t/t5580-unc-paths.sh
@@ -4,6 +4,7 @@ test_description='various Windows-only path tests'
 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 if test_have_prereq CYGWIN
diff --git a/t/t5615-alternate-env.sh b/t/t5615-alternate-env.sh
index b4905b822c0..83513e46a35 100755
--- a/t/t5615-alternate-env.sh
+++ b/t/t5615-alternate-env.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='handling of alternates in environment variables'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 check_obj () {
diff --git a/t/t7518-ident-corner-cases.sh b/t/t7518-ident-corner-cases.sh
index 905957bd0a1..fffdb6ff2e7 100755
--- a/t/t7518-ident-corner-cases.sh
+++ b/t/t7518-ident-corner-cases.sh
@@ -1,6 +1,8 @@
 #!/bin/sh
 
 test_description='corner cases in ident strings'
+
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 # confirm that we do not segfault _and_ that we do not say "(null)", as

-- 
2.33.0.1441.gbbcdb4c3c66
Previous: Ævar Arnfjörð BjarmasonNext: Ævar Arnfjörð Bjarmason
Message 12 of 27 in “leak tests: mark more tests as passing”
  1. 00/10 leak tests: mark more tests as passingÆvar Arnfjörð Bjarmason, Oct 6, 2021
  2. 01/10 leak tests: run various built-in tests in t00*.sh SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  3. Junio C HamanoOct 7, 2021
  4. 02/10 leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  5. 03/10 leak tests: mark t0000-init.sh as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  6. Junio C HamanoOct 7, 2021
  7. Ævar Arnfjörð BjarmasonOct 12, 2021
  8. 04/10 leak tests: mark all ls-tree tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  9. 05/10 leak tests: mark all trace2 tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  10. 07/10 leak tests: mark some ls-files tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  11. 06/10 leak tests: mark all checkout-index tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  12. 09/10 leak tests: mark various "generic" tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  13. 08/10 leak tests: mark some read-tree tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  14. 10/10 leak tests: mark some misc tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 6, 2021
  15. Elijah NewrenOct 6, 2021
  16. Junio C HamanoOct 7, 2021
  17. Ævar Arnfjörð BjarmasonOct 12, 2021
  18. 0/9 leak tests: mark more tests as passingÆvar Arnfjörð Bjarmason, Oct 12, 2021
  19. 1/9 leak tests: run various built-in tests in t00*.sh SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  20. 2/9 leak tests: run various "test-tool" tests in t00*.sh SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  21. 3/9 leak tests: mark all ls-tree tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  22. 4/9 leak tests: mark all trace2 tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  23. 5/9 leak tests: mark all checkout-index tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  24. 6/9 leak tests: mark some ls-files tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  25. 7/9 leak tests: mark some read-tree tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  26. 8/9 leak tests: mark various "generic" tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021
  27. 9/9 leak tests: mark some misc tests as passing with SANITIZE=leakÆvar Arnfjörð Bjarmason, Oct 12, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.