Re: [PATCH 06/11] doc: trailer: trailer.<token>.cmd: add missing verb phrase
- From
- Linus Arver <linusa@google.com>
- Date
- May 10, 2023, 06:52 UTC
- Message-ID
- <owlyjzxgn0et.fsf@fine.c.googlers.com>
- In-Reply-To
- <xmqq1qjqobl9.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
> "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> From: Linus Arver <linusa@google.com>
>> The phrase "is specified" is implied. Make it explicit.
> Makes sense. Calling it "implied" is generous ;-)
Haha yes, I suppose so. I wrote "implied" because supplying the (missing) phrase "is specified" was the only way I could make sense of the existing wording.
> Isn't the > original just outright ungrammatical?
Indeed.
Should I combine 01+06 together?
>> Signed-off-by: Linus Arver <linusa@google.com> >> --- >> Documentation/git-interpret-trailers.txt | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-)
Show 8 quoted lines
>> diff --git a/Documentation/git-interpret-trailers.txt >> b/Documentation/git-interpret-trailers.txt >> index e80a9cd161b..c4675d9d3bb 100644 >> --- a/Documentation/git-interpret-trailers.txt >> +++ b/Documentation/git-interpret-trailers.txt >> @@ -248,10 +248,10 @@ for the same <token>, 'trailer.<token>.cmd' is >> used and >> 'trailer.<token>.command' is ignored.
Show 17 quoted lines
>> trailer.<token>.cmd:: >> - This option can be used to specify a shell command that will be called: >> - once to automatically add a trailer with the specified <token>, and >> then >> - each time a '--trailer <token>=<value>' argument to modify the <value> >> of >> - the trailer that this option would produce. >> + This option can be used to specify a shell command that will be called >> once >> + to automatically add a trailer with the specified <token>, and then >> called >> + each time a '--trailer <token>=<value>' argument is specified to >> modify the >> + <value> of the trailer that this option would produce. >> + >> When the specified command is first called to add a trailer >> with the specified <token>, the behavior is as if a special