Re: [PATCH] trailer: fix comment/cut-line regression with opts->no_divider

From: Linus Arver <linusa@google.com>
Date: Mar 8, 2024, 02:21 UTC
Message-ID: <owlyfrx14g63.fsf@fine.c.googlers.com>
In-Reply-To: <20240220010936.GA1793660@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> On Mon, Feb 19, 2024 at 10:42:45AM -0800, Junio C Hamano wrote:
> [...]
>
> The fix itself is pretty simple: instead of returning early, no_divider
> just skips the "---" handling but still calls ignored_log_message_bytes().

I realize I am late to the discussion, but this fix (and patch) looks right to me. FWIW I independently discovered the same problem and figured out a fix locally in my larger refactor of this area (with the same fix, to always call ignored_log_message_bytes() regardless of no_divider). Thank you Peff!

Sorry for introducing the regression. My enthusiasm in changing things up without unit tests is regrettable.