Re: What's cooking in git.git (Sep 2023, #05; Fri, 15)

From: Linus Arver <linusa@google.com>
Date: Sep 20, 2023, 06:37 UTC
Message-ID: <owly1qetjqo1.fsf@fine.c.googlers.com>
In-Reply-To: <xmqq34z9g8jz.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 26 quoted lines

> Linus Arver <linusa@google.com> writes:
>
>> Junio C Hamano <gitster@pobox.com> writes:
>>
>>> [Cooking]
>>>
>>> [...]
>>>
>>> * la/trailer-cleanups (2023-09-11) 6 commits
>>>   (merged to 'next' on 2023-09-12 at 779c4a097a)
>>>  + trailer: use offsets for trailer_start/trailer_end
>>>  + trailer: rename *_DEFAULT enums to *_UNSPECIFIED
>>>  + trailer: teach find_patch_start about --no-divider
>>>  + trailer: split process_command_line_args into separate functions
>>>  + trailer: split process_input_file into separate pieces
>>>  + trailer: separate public from internal portion of trailer_iterator
>>>
>>>  Code clean-up.
>>>
>>>  Will merge to 'master'.
>>>  source: <pull.1563.v2.git.1694240177.gitgitgadget@gmail.com>
>>
>> This isn't ready yet (still need to reroll).
>
> Whoa, wait.  I wasn't aware of any more comments that needed
> addressing.

Perhaps you missed my comment [1]?

Show 6 quoted lines

> Whatever improvements you have in mind, if they are
> minor, letting the above graduate (they have been in 'next' for a
> week without anybody complaining) and doing them as a follow-up
> series would be sensible, I would think.
>
> Thanks.

Hmm, I don't think they are minor? See https://github.com/listx/git/tree/trailer-libification-prep for the current state of things.

I need to still follow up to your last comment on "trailer: rename *_DEFAULT enums to *_UNSPECIFIED" [2] (I was going to see if we needed the "obvious solution" as you described).

If it's too painful to move this out of 'next' now, I'm OK with it graduating as is and doing a separate follow-up (I expect several more of these to happen anyway). Up to you.

Sorry for not noticing that this was in 'next' sooner and communicating accordingly.

[1] https://lore.kernel.org/git/pull.1563.git.1691211879.gitgitgadget@gmail.com/T/#m0131f9829c35d8e0103ffa88f07d8e0e43dd732c [2] https://lore.kernel.org/git/pull.1563.git.1691211879.gitgitgadget@gmail.com/T/#md4ff2235720e921a2e031665f4da054d82edd506