Re: [PATCH 1/1] http: don't send C or POSIX in Accept-Language

From: Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date: Jul 11, 2025, 20:22 UTC
Message-ID: <owlvoi7beap4mx2tejuny26xo4jpzzpxkz7243erlhpgu7oa2u@q7fuycw32ds6>
In-Reply-To: <xmqqldou1suk.fsf@gitster.g>

On Fri, Jul 11, 2025 at 11:32:19AM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> Justin Tobler <jltobler@gmail.com> writes:
> 
> > Looking at `get_preferred_languages()` when NO_GETTEXT is defined, we
> > already filter out "C" and "POSIX". So doing this for the LANGUAGE
> > environment variable when writing the header also makes sense.
> 
> True.  I wonder if it makes sense to do the check in that helper
> function, though.  I.e. something like

Definitely, and might also fix another bug, as IMHO the current logic have a couple of issues:

* LANGUAGE is not meant to be relevant unless LANG is set to a valid locale
  as per the SPEC[1], allthough for our use case it might be better to still
  do, specially if there are users in the wild setting C and POSIX there.
* it might make more sense to use the union of LANGUAGE and LC_MESSAGES
  instead.

Carlo