Re: [PATCH v2 2/2] send-email: handle adjacent RFC 2047-encoded words properly
- From
Роман Донченко <dpb@corrigendum.ru>
- Date
- Dec 7, 2014, 18:17 UTC
- Message-ID
- <op.xqifqmyznngjn5@freezie>
- In-Reply-To
- <316EF32F3157400882911A84EA0CFC61@PhilipOakley>
Philip Oakley <philipoakley@iee.org> писал в своём письме Sun, 07 Dec 2014 20:48:05 +0300:
Show 28 quoted lines
> From: "Роман Донченко" <dpb@corrigendum.ru> >> Jeff King <peff@peff.net> писал в своём письме Sun, 07 Dec 2014 >> 12:18:59 +0300: >> >>> On Sat, Dec 06, 2014 at 10:36:23PM +0300, Роман Донченко wrote: >>> One final note on this bit of code: if there are multiple encoded >>> words, >>> we grab the $charset from the final encoded word, and never report the >>> earlier charsets. Technically they do not all have to be the same >>> (rfc2047 even has an example where they are not). I think we can >>> dismiss >>> this, though, as: >>> >>> 1. It was like this before your patches (we might have seen multiple >>> non-adjacent encoded words; you're just handling adjacent ones), >>> and nobody has complained. >>> >>> 2. Using two separate encodings in the same header is sufficiently >>> ridiculous that I can live with us not handling it properly. >> >> Yeah, that bugs me as well. But I think handling multiple encodings >> would require substantial reworking of the code, so I chickened out >> (with the same excuses :-)). > > Would that be worth a terse comment in the documentation change part of > the patch? > "Multiple (RFC2047) encodings are not supported.", > or would that be bike shed noise.
I didn't change any documentation... and in either case, they weren't supported in the first place, so I don't think it's anything I need to mention.