Re: Two problems on alias of git

From: Kana Natsuno <kana@whileimautomaton.net>
Date: May 5, 2009, 15:11 UTC
Message-ID: <op.utgptirm6f2obg@i220-99-253-139.s27.a098.ap.plala.or.jp>
In-Reply-To: <m3bpq7oddw.fsf@localhost.localdomain>

On Tue, 05 May 2009 23:03:49 +0900, Jakub Narebski <jnareb@gmail.com> wrote:

Show 11 quoted lines

> I don't know if it is a bug or a feature, but git-config supports
> quoted strings (required if you want to have value which has trailing
> or leading whitespace, or which contains '#' which is beginning of
> comment character).  Inside quoted string you need to escape '"':
>
>    [string]
>         quotes = "quoted \" string ' with # character"
>
> expands as intended.  Perhaps stripping of double quotes
> inside string are artifact of that feature.  Try escaping or
> double escaping quotes: \" or \\\".

Thank you for the information. I've read the source code of git and I confirmed that this stripping is caused by parse_value() in config.c.

And as I changed the old definition

        lr = !$SHELL -c 'n=10; 1="${1:-$n}"; ...' __dummy__

by enclosing all text in double quotes and substituting '"' with '\"' as follows,

	lr = "!$SHELL -c 'n=10; 1=\"${1:-$n}\"; ...' __dummy__"

it works well now.

	$ git config --get alias.lr
	!$SHELL -c 'n=10; 1="${1:-$n}"; if ! [ "${1##[0-9]*}" ...

-- 
To Vim, or not to Vim.
http://whileimautomaton.net/