Re: Git-SVN on Cygwin: svn+ssh good, https awkward

From: Matthias Andree <matthias.andree@gmx.de>
Date: Apr 23, 2009, 18:16 UTC
Message-ID: <op.usuqcyp81e62zd@balu.cs.uni-paderborn.de>
In-Reply-To: <loom.20090423T175124-165@post.gmane.org>

Am 23.04.2009, 19:58 Uhr, schrieb Eric Blake <ebb9@byu.net>:

Show 7 quoted lines

>> Can we use unique tempfile names (timestamps, counter, random number
>> generator) instead of the hardcoded "tempfile.tmp"? This is probably a
>> good idea anyways to evade symlink attacks.
>
> Although newer cygwin may fix your particular problem, this is not a bad
> suggestion for msysgit, so I suspect someone may be bothered enough by  
> this to write a patch.  I, however, will not be the one doing it.

Hi Eric,

thanks for the hints and pointers to Cygwin 1.7 beta, however I'd suggest to make such changes upstream (i. e. in git.git) for the benefit of everybody else.

It also looks to me as though minor changes in the actual baseline Git code may be sufficient to get git-svn working on Cygwin 1.5 (stable) already. I'd prefer such a minor intrusion to hacking away on forks. :-)

Otherwise I'd start looking at how git-svn handles https:// and svn+ssh:// methods differently from each other next week or so.

Looking forward to further insights.

-- 
Matthias Andree