Re: Misrendering of git 2.24 log --graph

From: Jan Engelhardt <jengelh@inai.de>
Date: Jan 24, 2020, 16:08 UTC
Message-ID: <nycvar.YFH.7.76.2001241652250.32144@n3.vanv.qr>
In-Reply-To: <b64e8fb7-1dd3-439f-6ab1-1b88c52879d1@gmail.com>

On Friday 2020-01-24 15:05, Derrick Stolee wrote:

Show 10 quoted lines

>> I have observed git 2.24 outputting a garbage graph element for a 
>> particular history.
>
>I initially thought you were right, as 2.25 did include some new
>rendering, and we've already found and fixed a regression [1] and
>a style issue [2].
>[...]
>Here is something I noticed: this does not reproduce without a
>commit-graph! That's likely because it changes the order of the
>initial refs. Keep that in mind for anyone trying to repro this.

Curiously, I need no --mirror for `git clone`, the default clone operation is just fine. It has, as far as I can remember back, always downloaded all origin:refs/heads/* and refs/tags/*.

>However, I see this output with 2.24.1:

Show 6 quoted lines

>| | | _   
>| | * 79106b731 doc: update 8.7.x news
>
>and this output in 2.25.0 [...]
>
>Is it possible that you are not running the version you think you are?

I rerun my checks as I write this mail. The observations:

 * Built v2.23.0 from source, ran it via `../tmpdir/git/git log --andsoon`,
   shows said underscore.
 * Built v2.24.0 from source, shows underscore
 * Built v2.24.1 from source, shows underscore
 * Used v2.24.1 from distro (/usr/bin/git), renders underscore
 * Built ead10bacc466a409490fb743d7805893976f8f53 (most recent 
   branch join not having v2.25 as an ancestor) from src, 
   shows underscore
 * Built v2.25.0 from source, new rendering
 * Built 631a7dec11, same as v2.25.0
 * Built 631a7dec11^, same as v2.25.0