js/scalar-diagnose, was Re: What's cooking in git.git (May 2022, #04; Thu, 12)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 13, 2022, 12:06 UTC
Message-ID: <nycvar.QRO.7.76.6.2205131404280.352@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqilqacmmd.fsf@gitster.g>

Hi Junio,

On Thu, 12 May 2022, Junio C Hamano wrote:

Show 14 quoted lines

> * js/scalar-diagnose (2022-05-12) 8 commits
>  - fixup: archive: optionally add "virtual" files
>  - scalar: teach `diagnose` to gather loose objects information
>  - scalar: teach `diagnose` to gather packfile info
>  - scalar diagnose: include disk space information
>  - scalar: implement `scalar diagnose`
>  - scalar: validate the optional enlistment argument
>  - archive --add-file-with-contents: allow paths containing colons
>  - archive: optionally add "virtual" files
>
>  Implementation of "scalar diagnose" subcommand.
>
>  Will merge to 'next' after squashing the fix in?
>  source: <pull.1128.v4.git.1652210824.gitgitgadget@gmail.com>

Yes, please!

My first reaction was: but wait, what about the file mode? Then I remembered that René offered the opinion that we could easily introduce `--add-executable-file-with-contents` _iff_ we need that at some stage, and when I considered symbolic links, I noticed that the `--add-file` option does not accept those in the first place, so it would be funny if `--add-file-with-contents` supported symbolic links.

Thanks, Dscho