Re: [PATCH v3 2/4] ci: avoid brew for installing perforce
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 26, 2022, 15:55 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2204261747530.355@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20220423142559.32507-3-carenas@gmail.com>
Hi Carlo,
On Sat, 23 Apr 2022, Carlo Marcelo Arenas Belón wrote:
Show 19 quoted lines
> diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh
> index 41e9290fbdd..9da03350d09 100755
> --- a/ci/install-dependencies.sh
> +++ b/ci/install-dependencies.sh
> @@ -37,13 +37,14 @@ macos-latest)
> test -z "$BREW_INSTALL_PACKAGES" ||
> brew install $BREW_INSTALL_PACKAGES
> brew link --force gettext
> - brew install --cask --no-quarantine perforce || {
> - # Update the definitions and try again
> - cask_repo="$(brew --repository)"/Library/Taps/homebrew/homebrew-cask &&
> - git -C "$cask_repo" pull --no-stat --ff-only &&
> - brew install --cask --no-quarantine perforce
> - } ||
> - brew install homebrew/cask/perforce
> + mkdir -p $HOME/bin
> + (
> + cd $HOME/bin
> + wget -q "https://cdist2.perforce.com/perforce/r21.2/bin.macosx1015x86_64/helix-core-server.tgz" &&I vaguely recall that Gábor Szeder attempted something similar, but I _think_ that ultimately there were too many moving parts in that URL that we did not want to hardcode.
For example, when opening a PR against `maint` or an even older topic branch, we are stuck with the exact code in that revision that obtains the perforce package. But since that server is outside our control, it can very well evolve to a state that is not amenable to hard-coding such a URL.
While I don't think that we can solve this fully, I would prefer to keep the existing `brew install` calls but fall back to downloading from a hard-coded URL. That still would have the shortcoming of hard-coded `r21.2` and `1015`, but it should fail less often than the proposed patch.
For the record, the recent problems stem from the fact that the package was cached on GitHub's build agents (I guess to avoid many identical downloads), and the cached package did not match what was recorded in the updated package definition. Which means that those `brew` errors are only transient, until a new VM image is built that caches the then-current perforce package.
Ciao, Dscho
Show 11 quoted lines
> + tar -xf helix-core-server.tgz
> + )
> + PATH="$PATH:${HOME}/bin"
> + export PATH
>
> if test -n "$CC_PACKAGE"
> then
> --
> 2.36.0.266.g59f845bde02
>
>