Re: Git 2.36, ls-tree submodule regression?
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 7, 2022, 12:37 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2204071436150.347@tvgsbejvaqbjf.bet>
- In-Reply-To
- <20220407022207.12542-1-dyroneteng@gmail.com>
Hi,
On Thu, 7 Apr 2022, Teng Long wrote:
Show 29 quoted lines
> > Bisecting the error selects: > > > > $ git bisect good > > 9c4d58ff2c385f49585197c8650356955e1fa02e is the first bad commit > > commit 9c4d58ff2c385f49585197c8650356955e1fa02e > > Author: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > > Date: Wed Mar 23 17:13:15 2022 +0800 > > > > ls-tree: split up "fast path" callbacks > > > > Make the various if/else in the callbacks for the "fast path" a lot > > easier to read by just using common functions for the parts that are > > common, and have per-format callbacks for those parts that are > > different. > > > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > > Signed-off-by: Teng Long <dyroneteng@gmail.com> > > Signed-off-by: Junio C Hamano <gitster@pobox.com> > > > > builtin/ls-tree.c | 199 ++++++++++++++++++++++++++++++++++-------------------- > > 1 file changed, 125 insertions(+), 74 deletions(-) > > > > (I've CC'd Ævar and Teng on this message.) > > > > Looking at the changes in that commit I see differences in the > > handling for long listings, so I tried removing the -l. At that point, > > the command works again: > > Yes, it's a bug but already found and fixed by Ævar Arnfjörð Bjarmason.
Correction, it was fixed by Josh Steadmon, and Ævar proposed an alternative, but Josh's version made it into the `main` branch:
https://github.com/git/git/commit/350296cc78912c245847ec65e55143053450cce1
Ciao, Johannes