Re: [PATCH] name-rev: test showing failure with non-monotonic commit dates
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Mar 9, 2022, 21:56 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2203092256070.357@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqr18515jr.fsf@gitster.g>
Hi Junio,
On Mon, 14 Feb 2022, Junio C Hamano wrote:
Show 21 quoted lines
> Jacob Keller <jacob.e.keller@intel.com> writes: > > > From: Jacob Keller <jacob.keller@gmail.com> > > > > If a commit in a sequence of linear history has a non-monotonically > > increasing commit timestamp, git name-rev will not properly name the > > commit. > > > > However, if you use --annotate-stdin then the commit does actually get > > picked up and named properly. > > IIRC, this is to be expected. > > When preparing to answer --annotate-stdin request, the command has > to dig down to the root of the history, which would be too expensive > in some repositories and wants to stop traversal early when it knows > particular commits it needs to describe. > > Dscho? I think this is pretty much a fundamental part of the > initial version added by bd321bcc (Add git-name-rev, 2005-10-26) and > kept that way to this day, I think.
Yes, it was.
Looks like Stolee had great suggestions while I did not find time to catch up with the mailing list.
Ciao, Dscho