Re: [PATCH 0/3] [Non-critical]: sparse index vs split index fixes

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 22, 2022, 09:31 UTC
Message-ID: <nycvar.QRO.7.76.6.2201221031250.2121@tvgsbejvaqbjf.bet>
In-Reply-To: <CABPp-BFXMMH2_qqWPGaWX76mqEs2Z1GFNzbyeu2rLgaFPt7JyQ@mail.gmail.com>

Hi Elijah,

On Fri, 21 Jan 2022, Elijah Newren wrote:

Show 18 quoted lines

> On Fri, Jan 21, 2022 at 11:53 AM Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > We noticed split/sparse index-related issues while rebasing Microsoft's fork
> > of Git. These fixes are necessary for that fork's test suite to pass, but
> > they might not be super critical to get into upstream v2.35.0 (especially
> > this close to -rc2). However, the team felt that the decision should be left
> > to the Git maintainer whether to take these patches into v2.35.0 or not.
>
> Thanks for digging into these and putting in some guardrails to
> prevent similar issues.  I hit similar things with some of my changes
> and had to fight t1091 to get it to pass in CI under
> GIT_TEST_SPLIT_INDEX=1.  I don't recall seeing the specific error you
> mention in patch 1, but maybe I just overlooked it.  I ended up
> finding little workarounds such as disabling sparse-checkouts at the
> end of various tests before new ones I was adding, and being extra
> careful to not leave the sparse-index selected.  I probably should
> have dug further, but didn't.  Thanks for digging in.

Seeing how much time it took to properly diagnose and fix these issues, I do not fault you ;-)

> I've read over the patch series; it looks good to me:
>
> Reviewed-by: Elijah Newren <newren@gmail.com>

Thank you! Dscho