Re: [PATCH] lazyload: use correct calling conventions

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 11, 2022, 22:33 UTC
Message-ID: <nycvar.QRO.7.76.6.2201112330480.1081@tvgsbejvaqbjf.bet>
In-Reply-To: <nycvar.QRO.7.76.6.2201111412300.1081@tvgsbejvaqbjf.bet>

Hi Junio,

On Tue, 11 Jan 2022, Johannes Schindelin wrote:

Show 15 quoted lines

> On Mon, 10 Jan 2022, Junio C Hamano wrote:
>
> > Dscho, how does this look?  My choices are
> >
> >  - Waiting for review.
> >  - Will merge to 'next'.
> >  - Will merge to 'next' and then to 'master'.
>
> My preference is the last option, merge it down quickly.
>
> > The last one will make it as part of Git 2.35.0 final, unless there
> > is some unexpected breakage found later.
>
> I do not expect anything to break. Just like Matthias, I actually expect
> future breakages to be fended off by this.

And that future is here already. We just got a report of a problem that is resolved by Matthias' patch: https://github.com/git-for-windows/git/pull/3624

> Merging it into v2.35.0 final will require a tiny fixup in
> `compat/win32/flush.c` (which we carry in Git for Windows already),
> [...]

And I did that, and opened a PR already, which I plan on merging soon: https://github.com/git-for-windows/git/pull/3626

Ciao, Dscho