Re: patch: change “Everything up-to-date” to “Already up to date.” (No-op messages for git-push and git-pull)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 3, 2021, 22:15 UTC
Message-ID: <nycvar.QRO.7.76.6.2112032310300.63@tvgsbejvaqbjf.bet>
In-Reply-To: <CAPig+cRRxYmFqYimTHSi9uzmWU0FRXQ2hGXJK6jYLJcsFce_Rw@mail.gmail.com>

Hi,

On Mon, 29 Nov 2021, Eric Sunshine wrote:

Show 19 quoted lines

> On Mon, Nov 29, 2021 at 7:04 PM Anselm Schüler <mail@anselmschueler.com> wrote:
> > Why are the no-op messages for git-push and git-pull (i.e. when remote
> > and local are identical) so different, while describing something very
> > similar? IMO the messages should be either identical or very similar.
> > git-pull results in “Already up to date.”, while git-push results
> > in “Everything up-to-date”.
> >
> > It should be considered that other messages reading “Already up to
> > date.” seem to use a translation system, it might be better to use
> > that system here, too. Unfortunately, I don’t know how to do that
> > (currently). At any rate, this patch could serve as a temporary
> > “fix”.
>
> This question/issue is raised from time to time, and the short answer
> is that send-pack is plumbing, thus there likely will be resistance to
> an arbitrary change of text. Denton goes into a bit more detail in his
> reply[1].
>
> [1]: https://lore.kernel.org/git/20191122180433.GA57478@generichostname/

As an additional data point: changing the `git pull` message (actually, the message comes from `merge-recursive.c`, I believe) from "up-to-date" to "up to date" in 7560f547e61 (treewide: correct several "up-to-date" to "up to date", 2017-08-23) broke applications parsing that message (IIRC Visual Studio was one of those who had to scramble to adjust their code accordingly).

So yes, we are pretty reluctant to change such central messages. Sometimes, correct grammar ain't worth the cost it incurs.

Ciao, Johannes