Re: [PATCH] completion: add human and auto: date format

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 25, 2021, 11:45 UTC
Message-ID: <nycvar.QRO.7.76.6.2111251245200.63@tvgsbejvaqbjf.bet>
In-Reply-To: <pull.1083.git.1637666875171.gitgitgadget@gmail.com>

Hi Yoichi,

On Tue, 23 Nov 2021, Yoichi NAKAYAMA via GitGitGadget wrote:

Show 9 quoted lines

> From: Yoichi Nakayama <yoichi.nakayama@gmail.com>
>
> human was introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc
> auto:* was introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182
>
> Those formats were missing when other values were added to completion
> at 5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Signed-off-by: Yoichi Nakayama <yoichi.nakayama@gmail.com>

The commit message and the patch look good to me.

Thanks! Dscho

Show 37 quoted lines

> ---
>     completion: add human and auto: date format
>
>     In bash/zsh completion for git log --date=, following values are
>     missing:
>
>      * human (introduced in acdd37769de8b0fe37a74bfc0475b63bdc55e9dc)
>      * auto:* (introduced in 2fd7c22992d37469db957e9a4d3884a6c0a4d182)
>
>     They did exist when other values were added to completion at
>     5a59a2301f6ec9bcf1b101edb9ca33beb465842f
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1083%2Fyoichi%2Flog-date-completion-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1083/yoichi/log-date-completion-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1083
>
>  contrib/completion/git-completion.bash | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 7c3a75373a4..37fd5c4c885 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2001,7 +2001,7 @@ __git_log_shortlog_options="
>  "
>
>  __git_log_pretty_formats="oneline short medium full fuller reference email raw format: tformat: mboxrd"
> -__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default raw unix format:"
> +__git_log_date_formats="relative iso8601 iso8601-strict rfc2822 short local default human raw unix auto: format:"
>
>  _git_log ()
>  {
>
> base-commit: 0ea906d20517145895193a99666d5f2860a04360
> --
> gitgitgadget
>